EddieHubCommunity / BioDrop

Connect to your audience with a single link. Showcase the content you create and your projects in one place. Make it easier for people to find, follow and subscribe.
https://biodrop.io
MIT License
5.72k stars 3.94k forks source link

[BUG] Account/Manage/Link button pointing to undefined. #10157

Closed girl-loves-coding closed 9 months ago

girl-loves-coding commented 9 months ago

Has this bug been raised before?

Where did you find this bug?

production

Version of BioDrop (for example "v1.2.3")

2.99.5

Description

The button preview is pointing to undefined.

image image

Steps to Reproduce

If you know the steps, follow the below format and provide steps to reproduce

For example:

  1. Go to https://www.biodrop.io/account/manage/link/{your link} page.
  2. Check the preview link button
  3. All the buttons for me show undefined

Screenshots

No response

Do you want to work on this issue?

No

If "yes" to above, please explain how you would technically implement this

No response

github-actions[bot] commented 9 months ago

To reduce notifications, issues are locked until they are https://github.com/EddieHubCommunity/BioDrop/labels/%F0%9F%8F%81%20status%3A%20ready%20for%20dev and to be assigned. You can learn more in our contributing guide https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md

github-actions[bot] commented 9 months ago

The issue has been unlocked and is now ready for dev. If you would like to work on this issue, you can comment to have it assigned to you. You can learn more in our contributing guide https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md

eddiejaoude commented 9 months ago

Great spot, thank you for raising the issue 👍 I will look into it

ℹī¸ eddiejaoude has some opened assigned issues: 🔧View assigned issues

sital002 commented 9 months ago

@eddiejaoude I think passing _id here will fix the issue link={{ name, url, icon, animation, _id: link._id }} Edit: This will only work on edit link if i try to add a new link it will break

eddiejaoude commented 9 months ago

Great point @sital002 👍 for the edit the id will solve it đŸ’¯ , I also created a workaround for when adding a new link and the click will still work - I just raised the PR https://github.com/EddieHubCommunity/BioDrop/pull/10164

ℹī¸ eddiejaoude has some opened assigned issues: 🔧View assigned issues