EddieHubCommunity / BioDrop

Connect to your audience with a single link. Showcase the content you create and your projects in one place. Make it easier for people to find, follow and subscribe.
https://biodrop.io
MIT License
5.73k stars 3.98k forks source link

[FEATURE] Add 404 page to all pages in a users account/* path #10292

Closed MaorBemdoo closed 2 months ago

MaorBemdoo commented 5 months ago

Is this a unique feature?

Is your feature request related to a problem/unavailable functionality? Please describe.

If a user already has a json file, you are adviced on the forms to continue using your json file while if you use the forms and you try to make a pr for your json file, the gh workflow for accounts fails, telling you you are already on the biodrop database so continue using forms. I have tried both so this is from experience

Proposed Solution

I suggest instead of telling a user to keep using their json file on their forms page(and yet they still edit on their forms page), all routes in account/ should redirect to a 404 page or say somthing like delete your json file first

Screenshots

No response

Do you want to work on this issue?

No

If "yes" to above, please explain how you would technically implement this

No response

github-actions[bot] commented 5 months ago

To reduce notifications, issues are locked until they are https://github.com/EddieHubCommunity/BioDrop/labels/%F0%9F%8F%81%20status%3A%20ready%20for%20dev and to be assigned. You can learn more in our contributing guide https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md

amandamartin-dev commented 4 months ago

I am not sure I am following and I think a 404 page would be very confusing to folks.

When I go to edit my profile in forms, there is a notification letting me know that I have a json file still and I should delete it. Do you not see this? delete-json-message

MaorBemdoo commented 4 months ago

I understand, my suggestion was that instead of advicing a user to delete their json data all routes to edit their profile on forms should redirect to a page telling them to keep using their json file(i.e they should not be able to edit on the forms)

amandamartin-dev commented 4 months ago

I understand, my suggestion was that instead of advicing a user to delete their json data all routes to edit their profile on forms should redirect to a page telling them to keep using their json file(i.e they should not be able to edit on the forms)

Users are allowed and encouraged to use forms regardless of if they started with the json profile. We would not want to discourage this, but if you think there is a way to make it more clear that you should use one or the other?

eddiejaoude commented 2 months ago

Thank you for the collaboration and discussion. I think for now, I will close this issue as I think it will cause more confusion.

ℹ️ eddiejaoude has some opened assigned issues: 🔧View assigned issues