Implement Hover Effect to Clarify Uneditable Links

EddieHubCommunity / BioDrop

Connect to your audience with a single link. Showcase the content you create and your projects in one place. Make it easier for people to find, follow and subscribe.

https://biodrop.io

MIT License

5.73k stars 3.96k forks source link

Implement Hover Effect to Clarify Uneditable Links #10348

Closed SohamRoy-01 closed 3 months ago

SohamRoy-01 commented 5 months ago

Add Hover Effect for Explaining Uneditable Links

Fixes Issue :-

closes #10215

Closes Issue :- #10215

Changes proposed

Implemented a hover effect to clarify uneditable links.

Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] My change requires changes to the documentation.
[x] All new and existing tests passed.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

Note to reviewers

I've made adjustments to the code to accommodate specific circumstances. Please review the changes and let me know if anything further is needed. @eddiejaoude

amandamartin-dev commented 5 months ago

Hey @SohamRoy-01 and @eddiejaoude - in looking back at this issue, I originally approved it thinking it was about the github profile link (which should not be edited as it's connected to your biodrop profile) However, on looking more closely - i see this is about the links page and a user SHOULD be able to edit their added links afaik.

This code is fine if we want it, but I'm confused as to why this field is blocked at all. Can anyone update me, am I missing something abotu why I should not be able to edit the url of a link that I have on my profile?

eddiejaoude commented 5 months ago

Because the stats are collected against the url, we have it that the url for the links cannot be changed and therefore are disabled input fields.

The issue is meant to show to the user why the url for the link can't be edited

amandamartin-dev commented 5 months ago

Because the stats are collected against the url, we have it that the url for the links cannot be changed and therefore are disabled input fields.

The issue is meant to show to the user why the url for the link can't be edited

Ah yes! It had been too long and I wasn't able to get that from the issue convo. Thanks Eddie!