search

EddieHubCommunity / BioDrop

Connect to your audience with a single link. Showcase the content you create and your projects in one place. Make it easier for people to find, follow and subscribe.
https://biodrop.io
5.75k stars 3.99k forks source link

[BUG] Tags Duplication #10349

Open feres7 opened 2 months ago

feres7 commented 2 months ago

Has this bug been raised before?

Where did you find this bug?

Production on biodrop.io

Version of BioDrop (for example "v1.2.3")

v2.100.2

Description

When adding tags to your profile or event ticket tags can be duplicated there is this text under the tags field (Separate tags with commas (tags cannot be duplicated and max 32 characters).) so the handler should not allow duplication and there is no condition for that

Steps to Reproduce

If you know the steps, follow the below format and provide steps to reproduce

For example:

  1. Go to Edit profile page.
  2. try to add tags with the same name

Screenshots

image image

Do you want to work on this issue?

Yes

If "yes" to above, please explain how you would technically implement this

This is the handler responsible for it (handleKeyUp) I will just add a condition If a duplicate tag is found image

github-actions[bot] commented 2 months ago

To reduce notifications, issues are locked until they are https://github.com/EddieHubCommunity/BioDrop/labels/%F0%9F%8F%81%20status%3A%20ready%20for%20dev and to be assigned. You can learn more in our contributing guide https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md

amandamartin-dev commented 2 months ago

I believe this is not a bug and rather a decision so that users are not blocked from creating their profiles in any manner they wish. I will leave this in triage for other maintainers to weigh in. Thank you for the suggestion

eddiejaoude commented 1 month ago

Thank you for raising the issue.

I think at one point it was unique, I can't remember if it changed by mistake or was a design decision 🤔