EddieHubCommunity / BioDrop

Connect to your audience with a single link. Showcase the content you create and your projects in one place. Make it easier for people to find, follow and subscribe.
https://biodrop.io
MIT License
5.73k stars 3.96k forks source link

feat: archiving project redirect to github profile #10386

Closed eddiejaoude closed 3 months ago

eddiejaoude commented 3 months ago

Fixes Issue

Redirect all profile requests to their GitHub profile

For example BioDrop.io/eddiejaoude -> GitHub.com/eddiejaoude

Changes proposed

Check List (Check all the applicable boxes)

Screenshots

Note to reviewers

eddiejaoude commented 3 months ago

Hi @amandamartin-dev , sorry for my slow reply and thank you for testing! Every URI will redirect because we don't know if it is a username or an actual page like homepage or docs.

I guess you visited the homepage of BioDrop? Which redirected you to the homepage of GitHub.

We are not announcing that BioDrop will redirect as we prefer people to stop using their BioDrop URL, but we still see people using it so I was keen to not have a broken link for people and redirect to their GitHub profile (if their personal BioDrop page was visited - I was not worrying about pages like the homepage or the docs page etc)

amandamartin-dev commented 3 months ago

Hi @amandamartin-dev , sorry for my slow reply and thank you for testing! Every URI will redirect because we don't know if it is a username or an actual page like homepage or docs.

I guess you visited the homepage of BioDrop? Which redirected you to the homepage of GitHub.

We are not announcing that BioDrop will redirect as we prefer people to stop using their BioDrop URL, but we still see people using it so I was keen to not have a broken link for people and redirect to their GitHub profile (if their personal BioDrop page was visited - I was not worrying about pages like the homepage or the docs page etc)

Ah okay - so the main page definitely redirects. I will check some other pages an profiles as well to confirm thre as well. Thanks!

eddiejaoude commented 3 months ago

Thanks @amandamartin-dev for testing again. Yes it will do all paths to GitHub paths - I know it does more than we need, but not sure how to only include profiles as we won't have the DB anymore and I just want to have a very simple redirect app

I am open to any suggestions on how to make this better, but as there will be no website for people to navigate to /docs etc, I think the only links used will be profile links that have not been updated yet to another platform - so I think it is ok?

amandamartin-dev commented 3 months ago

Thanks @amandamartin-dev for testing again. Yes it will do all paths to GitHub paths - I know it does more than we need, but not sure how to only include profiles as we won't have the DB anymore and I just want to have a very simple redirect app

I am open to any suggestions on how to make this better, but as there will be no website for people to navigate to /docs etc, I think the only links used will be profile links that have not been updated yet to another platform - so I think it is ok?

Ah I see - without a database you could "whitelist" full URLs that redirect to a single page for biodrop explaining that the project has been sunset but encouraging folks to come explore other EddieHub Repos and join the community to stay up to date on whats next? wdyt?

eddiejaoude commented 3 months ago

Ah I see - without a database you could "whitelist" full URLs that redirect to a single page for biodrop explaining that the project has been sunset but encouraging folks to come explore other EddieHub Repos and join the community to stay up to date on whats next? wdyt?

I like the idea 👍 At least we could do it for the homepage. Thanks @amandamartin-dev

eddiejaoude commented 3 months ago

I also removed the header and the footer, to hopefully reduce confusion