EddieHubCommunity / BioDrop

Connect to your audience with a single link. Showcase the content you create and your projects in one place. Make it easier for people to find, follow and subscribe.
https://biodrop.io
MIT License
5.73k stars 3.96k forks source link

[FEATURE] [Add gitlab icon to linktree] #1045

Closed KendallDoesCoding closed 2 years ago

KendallDoesCoding commented 2 years ago

Description

Add gitlab icon to linktree

Screenshots

No response

Additional information

No response

github-actions[bot] commented 2 years ago

It's great having you contribute to this project

Welcome to the community :nerd_face:

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

KendallDoesCoding commented 2 years ago

I dont think a lot of people will be using Gitlab though? So, I don't think yall NEED to add this, coz people can use website links to the svg for now: https://about.gitlab.com/images/press/press-kit-icon.svg, but yall can take a call on this.

Panquesito7 commented 2 years ago

I dont think a lot of people will be using Gitlab though? So, I don't think yall NEED to add this, coz people can use website links to the svg for now: https://about.gitlab.com/images/press/press-kit-icon.svg, but yall can take a call on this.

That won't work as excepted, we don't use icons that way. Many people use GitLab, though. For example, I use it.

EmmaDawsonDev commented 2 years ago

Sure, this can be added. To add it needs importing from react icons in getIcons.js and adding to the switch statement in alphabetical order, a colour needs adding in config/links.json (also alphabetical) and it needs adding to the readme

KendallDoesCoding commented 2 years ago

I dont think a lot of people will be using Gitlab though? So, I don't think yall NEED to add this, coz people can use website links to the svg for now: https://about.gitlab.com/images/press/press-kit-icon.svg, but yall can take a call on this.

That won't work as excepted, we don't use icons that way. Many people use GitLab, though. For example, I use it.

Ok, then maybe I use it less lol

KendallDoesCoding commented 2 years ago

Sure, this can be added. To add it needs importing from react icons in getIcons.js and adding to the switch statement in alphabetical order, a colour needs adding in config/links.json (also alphabetical) and it needs adding to the readme

Do I need to do this?

EmmaDawsonDev commented 2 years ago

Do I need to do this?

If you want to do this issue then you will need to do all the steps, if you want to leave the issue for someone else to be assigned then that's also fine :)

KendallDoesCoding commented 2 years ago

Do I need to do this?

If you want to do this issue then you will need to do all the steps, if you want to leave the issue for someone else to be assigned then that's also fine :)

Ok cool! I'm not too good at react stuff so I'll leave this to someone else to do.

kaxada commented 2 years ago

@KendallDoesCoding I can jump onto this. can this be assigned to me @emmalearnscode ?

EmmaDawsonDev commented 2 years ago

@kaxada Go ahead, I will assign you :)

kaxada commented 2 years ago

@emmalearnscode interesting. let me navigate this

KendallDoesCoding commented 2 years ago

@KendallDoesCoding I can jump onto this. can this be assigned to me @emmalearnscode ?

Thanks