EddieHubCommunity / BioDrop

Connect to your audience with a single link. Showcase the content you create and your projects in one place. Make it easier for people to find, follow and subscribe.
https://biodrop.io
MIT License
5.72k stars 3.94k forks source link

Fix social media preview of LinkFree profile #3950

Closed aqib-m31 closed 1 year ago

aqib-m31 commented 1 year ago

Description

I shared my linkfree profile URL with a friend and I spotted - in profile preview the bio tag appears as markdown. It would be good if it appears as simple text without the markdown symbols.

Screenshots

WhatsApp Image 2023-01-25 at 13 40 53 Have a look below my name - asterisk symbols also appear.

Additional information

I don't know is it a bug or whatever! I thought it could be improved - so I learned how to refer an issue in an open source project!

github-actions[bot] commented 1 year ago

It's great having you contribute to this project

Welcome to the community :nerd_face:

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

gurjeetsinghvirdee commented 1 year ago

It's not a bug, you have to edit your data @aqib-m31

Screenshot 2023-01-25 142126
gurjeetsinghvirdee commented 1 year ago

It's a JSON file you can't write markdown inside it, make a new PR by removing those Asterisk

aqib-m31 commented 1 year ago

If I want some text to appear in bold or italic - how will I do that?

aqib-m31 commented 1 year ago

It's a JSON file you can't write markdown inside it, make a new PR by removing those Asterisk

I followed the QuickStart Documentation it shows you can use markdown in bio! @gurjeetsinghvirdee

Screenshot 2023-01-25 142846

gurjeetsinghvirdee commented 1 year ago

ok ok I got it, you didn't add space before "

gurjeetsinghvirdee commented 1 year ago
Screenshot 2023-01-25 143557

write like this @aqib-m31

aqib-m31 commented 1 year ago

It won't work. I tried to share @eddiejaoude profile on whatsapp - the asterisks appear on Eddie's profile also. @gurjeetsinghvirdee

aqib-m31 commented 1 year ago

WhatsApp Image 2023-01-25 at 14 51 11

gurjeetsinghvirdee commented 1 year ago

then better to remove this Asterisk

ChinmayMhatre commented 1 year ago

Hey @aqib-m31 , I tried it out myself and it does seem to be as you say. Maybe others contributors can take a look and see if they see any solution. Thank you for raising this issue! image

eddiejaoude commented 1 year ago

Thank you for raising the issue 👍

The markdown is currently only rendered when displaying on the LinkFree project, we can control how the previews are done with og: tags - we have a few of these but need to add more for the bio and render the markdown

eddiejaoude commented 1 year ago

Looking into this I am not sure the OG tags will allow rendered markdown, so we might have to strip them 🤔

aqib-m31 commented 1 year ago

From the json files?

SaraJaoude commented 1 year ago

We should keep the markdown in the json file as this is the source, but we can manipulate how it is used.

abhiiinav6 commented 1 year ago

There is String.replaceAll() method available in JavaScript. Using this method we can replace all "*" with empty string "".

ChinmayMhatre commented 1 year ago

I would like to give this a go.

ChinmayMhatre commented 1 year ago

After looking around, I only found that markdown cannot be added to the meta tags. I think we should just strip them for now.

abhiiinav6 commented 1 year ago

You don't get what I was saying. In Pagehead components they are passing data.bio as description. Instead of data.bio if pass data.bio.replaceAll("*",""), this will remove all the * from description.Screenshot_2023-02-13-17-45-17-12_320a9a695de7cdce83ed5281148d6f19.jpg

ChinmayMhatre commented 1 year ago

You don't get what I was saying. In Pagehead components they are passing data.bio as description. Instead of data.bio if pass data.bio.replaceAll("*",""), this will remove all the * from description.Screenshot_2023-02-13-17-45-17-12_320a9a695de7cdce83ed5281148d6f19.jpg

I totally got you. I was just searching if there was a way to add it. And This is exactly what I meant by stripping the markdown