search

EddieHubCommunity / BioDrop

Connect to your audience with a single link. Showcase the content you create and your projects in one place. Make it easier for people to find, follow and subscribe.
https://biodrop.io
MIT License
5.72k stars 3.94k forks source link

[BUG] Limited Display of Profiles in Search Results #9349

Closed Shiva-Sai-ssb closed 1 year ago

Shiva-Sai-ssb commented 1 year ago

Description

Edit: When searching for profiles using tags such as "open source" or "javascript," the Search results page only displays 20 profiles on a single page. This results in an unappealing layout with one empty space for a profile card. This issue is consistent across the all project pages. Increasing the profile card limit from 20 to 21 would resolve this problem. Please refer to the attached screenshot for visual clarity.

Screenshots

Top

Screenshot (43)

Bottom

Screenshot (44)

Do you want to work on this issue?

Yes

Additional information

Edit: Currently this is also reflect on the Discover page, but this page is to be removed as shown here: https://github.com/EddieHubCommunity/BioDrop/issues/9341

By increasing the results (changing from an even number to an odd number), this will fix it for three columns but break it for two columns. However as the two column size is less used, this can be ignored for now (and will be fixed as part of the upcoming redesign).

github-actions[bot] commented 1 year ago

To reduce notifications, issues are locked until they are https://github.com/EddieHubCommunity/BioDrop/labels/%F0%9F%8F%81%20status%3A%20ready%20for%20dev and to be assigned. You can learn more in our contributing guide https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md

SaraJaoude commented 1 year ago

@Shiva-Sai-ssb thank you for raising. Please see my edits and comments in the Issue description.

Could you please explain your proposed solution.

Shiva-Sai-ssb commented 1 year ago

@Shiva-Sai-ssb thank you for raising. Please see my edits and comments in the Issue description.

Could you please explain your proposed solution.

I'm new to this project. When I looked at the BioDrop website, I noticed an empty spot where a profile could go. So, I made a request to add a profile there. Yes, if we split it into two columns, there will be even more empty space because the profiles are small. The only way I can think of fixing this is by adding one profile.

SaraJaoude commented 1 year ago

@Shiva-Sai-ssb thank you for raising. Please see my edits and comments in the Issue description. Could you please explain your proposed solution.

I'm new to this project. When I looked at the BioDrop website, I noticed an empty spot where a profile could go. So, I made a request to add a profile there. Yes, if we split it into two columns, there will be even more empty space because the profiles are small. The only way I can think of fixing this is by adding one profile.

Thank you @Shiva-Sai-ssb - but by "explain your proposed solution" I meant, what section of code would you change.

Here is the section of the code that needs changing:

https://github.com/EddieHubCommunity/BioDrop/blob/553bed87c1023c8be8f76b8e11de7d934bc96854/pages/search.js#L198

I will assign this issue to you.

github-actions[bot] commented 1 year ago

The issue has been unlocked and is now ready for dev. If you would like to work on this issue, you can comment to have it assigned to you. You can learn more in our contributing guide https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md

Shiva-Sai-ssb commented 1 year ago

@Shiva-Sai-ssb thank you for raising. Please see my edits and comments in the Issue description. Could you please explain your proposed solution.

I'm new to this project. When I looked at the BioDrop website, I noticed an empty spot where a profile could go. So, I made a request to add a profile there. Yes, if we split it into two columns, there will be even more empty space because the profiles are small. The only way I can think of fixing this is by adding one profile.

Thank you @Shiva-Sai-ssb - but by "explain your proposed solution" I meant, what section of code would you change.

Here is the section of the code that needs changing:

https://github.com/EddieHubCommunity/BioDrop/blob/553bed87c1023c8be8f76b8e11de7d934bc96854/pages/search.js#L198

I will assign this issue to you.

Oops, my bad. I didn't understand what you meant when you said "explain your proposed solution". But yes, I knew which section of the code needs to be changed to fix the problem. Thank you for assigning the issue.

Abhishek9503 commented 1 year ago

The issue has been unlocked and is now ready for dev. If you would like to work on this issue, you can comment to have it assigned to you. You can learn more in our contributing guide https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md

I want to work on this issue please assign me this issue .I hope i could start my first contribution to the community by solving this issue.

Shiva-Sai-ssb commented 1 year ago

The issue has been unlocked and is now ready for dev. If you would like to work on this issue, you can comment to have it assigned to you. You can learn more in our contributing guide https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md

I want to work on this issue please assign me this issue .I hope i could start my first contribution to the community by solving this issue.

Hi, I've opened this issue and said that I'm ready to work on it. It's my first time contributing to this project, and I'll submit a pull request for it soon. Can you please check out other issues?

eddiejaoude commented 1 year ago

Don't worry @Shiva-Sai-ssb, the issue is assigned to you and I am going to review your PR now