search

EddieHubCommunity / EddieBotUI

EddieBotUI is the front end application that shows Eddie Jaoude Discord Community's public stats.
MIT License
16 stars 18 forks source link

Under maintenance and coming soon mode #33

Closed rossanodan closed 4 years ago

rossanodan commented 4 years ago

Is your feature request related to a problem? Please describe. It would be great having the Under Maintenance and the Coming Soon mode, especially now that the application is not ready to be displayed yet.

Describe the solution you'd like Using environment variables we can toggle on/off the two application states, giving a proper priority. Let me explain with an example.

Scenario 1

REACT_APP_UNDER_MAINTENANCE=false
REACT_APP_COMING_SOON=false

The application works normally, without any particular difference.

Scenario 2

REACT_APP_UNDER_MAINTENANCE=true
REACT_APP_COMING_SOON=false

The application shows only the under maintenance view, preventing the user to display any other part of the application. This state should be used only when massive changes are coming that risk to break the functionality.

Scenario 3

REACT_APP_UNDER_MAINTENANCE=false
REACT_APP_COMING_SOON=true

The application shows only the coming soon view, preventing the user to display any other part of the application. This state should be used only when parts of the application are not ready yet to be shown.

Scenario 4

REACT_APP_UNDER_MAINTENANCE=true
REACT_APP_COMING_SOON=true

The application shows only the under maintenance view, preventing the user to display any other part of the application. The under maintenance state has more priority.

These environment variables can be easily used in the application router.

github-actions[bot] commented 4 years ago

It's great having you contribute to this project:tada:

Feel free to raise an Issue! Welcome to the community :nerd_face:

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

eddiejaoude commented 4 years ago

Good idea. Some thoughts...

rossanodan commented 4 years ago

Good idea. Some thoughts...

  • Deploys will be fast, so not sure about under maintenance, but the coming soon holding page would be good now
  • Would coming soon always be needed, because once we get the first page up, there will always be something to show?

Agree about the under maintenance, pointless. The coming soon mode will be used only now, in the bootstrapping phase of the project. It's a placeholder until we'll have something to show.

rossanodan commented 4 years ago

Worked on this issue in https://github.com/EddieJaoudeCommunity/EddieBotUI/pull/34