search

EddieHubCommunity / EddieHubCommunity.github.io

Information about our community
http://eddiehub.org
Other
150 stars 122 forks source link

Jump to the top of the page instead of Linkedin Profile #303

Closed Satoshi-Sh closed 10 months ago

Satoshi-Sh commented 10 months ago

Description

Problem

When I clicked on Cahllagerfeld's LinkedIn Icon in the moderator section, it brought me to the top of the page. LinkedIn Url is set as "#" in the Moderator.jsx.

Fix

Need to put his LinkedIn URL instead of "#"

or

If he doesn't want to share his LinkedIn Profile here It's better not to render the icon.

Screenshots

Screenshot from 2023-11-04 16-51-48

Additional information

No response

rohan-kapse commented 10 months ago

hey, @Satoshi-Sh I agree, what can we do to fix it though?

eddiejaoude commented 10 months ago

Thank you for raising 👍

II fixed by checking for a url and then display the icon https://github.com/EddieHubCommunity/EddieHubCommunity.github.io/commit/77227c1287d13c64b2a547ca29afde4b307c24ae