EddieHubCommunity / EddieHubCommunity.github.io

Information about our community
http://eddiehub.org
Other
150 stars 122 forks source link

feat: improve accessibility of the project #313

Closed Hristo-Spasov closed 8 months ago

Hristo-Spasov commented 9 months ago

Fixes Issue

Closes #302

Changes proposed

One of the suggested changes is related to a <iframe> element which cannot be change within the Application,therefore is not changed.

Check List (Check all the applicable boxes)

Screenshots

Get started button

primaryFeatures

Note to reviewers

After picking up the issue i have to admit it took a minute until i can track the exact texts that need a change. With these changes I do believe the text looks better and is way more readable.

vercel[bot] commented 9 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2023 3:03pm
kkrishguptaa commented 9 months ago

Hi! Quick Question: Does this fix everything apart from the Element 6 (the one in the iframe)?

Hristo-Spasov commented 9 months ago

Yes,the errors from "Elements must meet minimum color contrast ratio thresholds to meet the WCAG 2 AA" that are not related to the iframe are gone.