EddieHubCommunity / EddieHubLive

Map to show EddieHub contributors
https://live.eddiehub.io
MIT License
47 stars 39 forks source link

fix: filtering out specific GitHub action events #43

Closed Chris-N closed 2 years ago

Chris-N commented 2 years ago

Fixes Issue

Close #30

Changes proposed

This will filter out the GitHub action events for "workflowRun", "checkSuite", and "checkRun".

Check List (Check all the applicable boxes)

Screenshots

Note to reviewers

In the issue #30 there are three events to hide and one was misspelled which was "checksuite". In my test I see that it should be camal case, "checkSuite". I am pointing it out if you noticed the difference from the write up.

Chris-N commented 2 years ago

A few checkboxes left uncheck as I wasn't sure but a couple of questions.

Appreciating all the info and help! 😄

eddiejaoude commented 2 years ago

Great work Chris! Looks good!

Were you able to test this manually?

Chris-N commented 2 years ago

Were you able to test this manually?

The way I was able to test this was from the suggestion early on, making a comment here, etc. Every so often I would get events while running which I assume was from others GitHub activity. That's how I was able to test it outside of trying to manually do it with curl or some mock data file I read on discord.

eddiejaoude commented 2 years ago

Ok great, thank you 👍