search

EddieHubCommunity / EventCalendar

Community events from TwitterSpaces to Live streams to Conferences
http://eventcalendar.eddiehub.org
MIT License
40 stars 43 forks source link

Change page title #25

Closed developer-diganta closed 2 years ago

developer-diganta commented 3 years ago

Changed the page title to "Event Calendar" (Closes #24 )

developer-diganta commented 3 years ago

@CodingSpecies Thank You for pointing it out. I have removed it. I deleted it. But I think this would not work?

NS007-dev commented 3 years ago

@CodingSpecies Thank You for pointing it out. I have removed it. I deleted it. But I think this would not work?

In the LinkFree repo in EddieHub, the package.json is always altered, so we tell them to take it out of the commits. We will see what the maintainers say. Thank you.

eddiejaoude commented 3 years ago

Great collaboration 👍

Deleting it is not a good idea, it is best to put it back to what it was, I think you can use

git checkout origin/master package-lock.json
NS007-dev commented 3 years ago

@eddiejaoude so in this repo do we not need to remove the package.json? Unless it is needed for this pull request?

eddiejaoude commented 3 years ago

We need to keep the package.json and package-lock.json files in the repo, but people should not commit these unless they made changes to the package.json file

NS007-dev commented 3 years ago

Ok thank you

developer-diganta commented 3 years ago

Should I change anything or wait for maintainers to instruct?

eddiejaoude commented 3 years ago

@developer-diganta https://github.com/EddieHubCommunity/EventCalendar/pull/25#issuecomment-962280718

developer-diganta commented 3 years ago

"error: pathspec 'origin/master' did not match any file(s) known to git " I get this error.. What can I do to resolve it?

mohan-murali commented 3 years ago

"error: pathspec 'origin/master' did not match any file(s) known to git " I get this error.. What can I do to resolve it?

We dont have a master branch. We have a main branch 😄

developer-diganta commented 3 years ago

@mohan-murali Thank you so much for pointing it out! I have done it....

eddiejaoude commented 3 years ago

Great collaboration everyone.

Thanks for the updates @developer-diganta , we can merge once the package-lock file is removed from the PR

developer-diganta commented 3 years ago

Sorry! Got a bit busy with college work.. I wanted to know how to remove the file from the pr?

eddiejaoude commented 3 years ago

No problem.

I added a comment previously https://github.com/EddieHubCommunity/EventCalendar/pull/25#issuecomment-962280718

developer-diganta commented 2 years ago

@eddiejaoude I have run that command. Is there anything else that I should do?

gptkrsh commented 2 years ago

@eddiejaoude I have run that command. Is there anything else that I should do?

@developer-diganta An easy way would be to just copy-paste the file from this repo, Created PR: https://github.com/developer-diganta/EventCalendar/pull/1

gptkrsh commented 2 years ago

Hey there @developer-diganta 👋 Just checking in, do you need any help?

developer-diganta commented 2 years ago

Sorry! I had not seen this for quite some time now. I think the changes this PR targeted has already been made. Shall I close this PR?