Closed itsharshitrwt closed 8 months ago
@itsharshitrwt is attempting to deploy a commit to the EddieHub Team on Vercel.
A member of the Team first needs to authorize it.
The recent modifications primarily focus on enhancing visual accessibility and aesthetic appeal within the UI. By adjusting text colors for better contrast and readability, these changes aim to address accessibility concerns while also refreshing the UI's look.
File(s) | Change Summary |
---|---|
src/components/Activity.js |
Updated class names and text colors for better contrast and visual accessibility. |
Objective | Addressed | Explanation |
---|---|---|
Address the insufficient color contrast issue (#120) | β | The changes do not match the specified foreground color #74859b for accessibility. |
Modify the foreground color to #74859b and retain the original background color #0f1623 (#120) | β | The foreground colors have been changed to "text-white" and "text-green-500", not #74859b . |
Verify the accessibility of the new colors using a color analyzer app before implementation (#120) | β | It's unclear if a color analyzer app was used to verify the accessibility of the new colors. |
In the realm of code, where changes are bold,
A rabbit hopped in, with intentions gold.
ππ» With tweaks and twists, the UI shines,
"For accessibility," it chimes.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Hi @itsharshitrwt. I highly recommend reading coderabbitβs feedback on your contribution.
Hi @Abiji-2020 , Thank you for your valuable feedback , but I'm quiet confused because Eddie said not to apply custom colors. Can you please elaborate it more like via screenshot? Thanks
Hi @Abiji-2020 , Thank you for your valuable feedback , but I'm quiet confused because Eddie said not to apply custom colors. Can you please elaborate it more like via screenshot? Thanks.
This was the changes made by you .
and the preferred colour changes in the issue is being given as
by providing the hex values of the colours for foreground and background. So in my personal opinion it is better if the colours are given in the hex value
Hi @Abiji-2020 , Thank you for your valuable feedback , but I'm quiet confused because Eddie said not to apply custom colors. Can you please elaborate it more like via screenshot? Thanks.
This was the changes made by you, and the preferred colour changes in the issue is being made as .
.
by providing the hex values of the colours for foreground and background. So in my personal opinion it is better if the colours are given in the hex value
Hi @Abiji-2020. When it comes to displaying code, it's best to do them as snippets like this:
<img src="url">
It'll make it easier for people to understand your points
Hi @Abiji-2020 , Thank you for your valuable feedback , but I'm quiet confused because Eddie said not to apply custom colors. Can you please elaborate it more like via screenshot? Thanks.
This was the changes made by you, and the preferred colour changes in the issue is being made as . . by providing the hex values of the colours for foreground and background. So in my personal opinion it is better if the colours are given in the hex value
Hi @Abiji-2020. When it comes to displaying code, it's best to do them as snippets like this:
<img src="url">
It'll make it easier for people to understand your points
Thankyou @CBID2 hereafter I try to follow those
Using tailwind colours is great π There should be enough options without needing to create new colours as suggested by CodeRabbit
Yay you made your first open source contribution @itsharshitrwt! π
Thankyou so much Everyone for helping me π specially @CBID2 .
Thankyou so much Everyone for helping me π specially @CBID2 .
Yup! :) I highly recommend using this website to post about contribution. Also, now that you've made your first contribution, I highly recommend checking out pizza-verse. It's one of OpenSauced's many repos that you can contribute to, and it focuses on pizza :)
Hi Folks , I checked the reporater's website , When i opened the website first time everything looks fine but when i opened it second time i see the green color is added to links and not to the "Rated " element and also white color was not visible to the time element . I'm just concerned about it now.π Even though the first time i opened it everything went as expected.
Screenshot:
Thankyou so much Everyone for helping me π specially @CBID2 .
Yup! :) I highly recommend using this website to post about contribution. Also, now that you've made your first contribution, I highly recommend checking out pizza-verse. It's one of OpenSauced's many repos that you can contribute to, and it focuses on pizza :)
Thanks @CBID2 , I will surely checkout the website.
Hi Folks , I checked the reporater's website , When i opened the website first time everything looks fine but when i opened it second time i see the green color is added to links and not to the "Rated " element and also white color was not visible to the time element . I'm just concerned about it now.π Even though the first time i opened it everything went as expected.
I moved the colours around after merging your PR, you can check the commit history - I thought the repo url will be better to be more highlighted instead
Hi Folks , I checked the reporater's website , When i opened the website first time everything looks fine but when i opened it second time i see the green color is added to links and not to the "Rated " element and also white color was not visible to the time element . I'm just concerned about it now.π Even though the first time i opened it everything went as expected.
I moved the colours around after merging your PR, you can check the commit history - I thought the repo url will be better to be more highlighted instead
Thanks Eddie for clarifying this , I got worried that I made some mistake π .
This issue fixes the problems related to background and foreground color visibility.
Fixes #120
Screenshots
Color - Analyzer tests:- (For white color)
(For Green color)
Summary by CodeRabbit