EddieHubCommunity / RepoRater

Rate GitHub Repos for Developer Experience (DX)
https://repo-rater.eddiehub.org
MIT License
154 stars 36 forks source link

fix: Color contrast issue #125

Closed itsharshitrwt closed 8 months ago

itsharshitrwt commented 8 months ago

This issue fixes the problems related to background and foreground color visibility.

Fixes #120

Screenshots

Screenshot 2024-01-27 130203

Color - Analyzer tests:- (For white color)

Screenshot 2024-01-29 135624

(For Green color)

Screenshot 2024-01-29 135549

Summary by CodeRabbit

vercel[bot] commented 8 months ago

@itsharshitrwt is attempting to deploy a commit to the EddieHub Team on Vercel.

A member of the Team first needs to authorize it.

coderabbitai[bot] commented 8 months ago

Walkthrough

The recent modifications primarily focus on enhancing visual accessibility and aesthetic appeal within the UI. By adjusting text colors for better contrast and readability, these changes aim to address accessibility concerns while also refreshing the UI's look.

Changes

File(s) Change Summary
src/components/Activity.js Updated class names and text colors for better contrast and visual accessibility.

Assessment against linked issues

Objective Addressed Explanation
Address the insufficient color contrast issue (#120) ❌ The changes do not match the specified foreground color #74859b for accessibility.
Modify the foreground color to #74859b and retain the original background color #0f1623 (#120) ❌ The foreground colors have been changed to "text-white" and "text-green-500", not #74859b.
Verify the accessibility of the new colors using a color analyzer app before implementation (#120) ❓ It's unclear if a color analyzer app was used to verify the accessibility of the new colors.

Poem

In the realm of code, where changes are bold,
A rabbit hopped in, with intentions gold.
πŸ‡πŸ’» With tweaks and twists, the UI shines,
"For accessibility," it chimes.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips ### Chat There are 3 ways to chat with CodeRabbit: - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit-tests for this file.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit tests for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository from git and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit tests.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json` ### CodeRabbit Discord Community Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback.
CBID2 commented 8 months ago

Hi @itsharshitrwt. I highly recommend reading coderabbit’s feedback on your contribution.

itsharshitrwt commented 8 months ago

Hi @Abiji-2020 , Thank you for your valuable feedback , but I'm quiet confused because Eddie said not to apply custom colors. Can you please elaborate it more like via screenshot? Thanks

Abiji-2020 commented 8 months ago

Hi @Abiji-2020 , Thank you for your valuable feedback , but I'm quiet confused because Eddie said not to apply custom colors. Can you please elaborate it more like via screenshot? Thanks.

This was the changes made by you .

and the preferred colour changes in the issue is being given as

by providing the hex values of the colours for foreground and background. So in my personal opinion it is better if the colours are given in the hex value

CBID2 commented 8 months ago

Hi @Abiji-2020 , Thank you for your valuable feedback , but I'm quiet confused because Eddie said not to apply custom colors. Can you please elaborate it more like via screenshot? Thanks.

image

This was the changes made by you, and the preferred colour changes in the issue is being made as image .

image .

by providing the hex values of the colours for foreground and background. So in my personal opinion it is better if the colours are given in the hex value

Hi @Abiji-2020. When it comes to displaying code, it's best to do them as snippets like this:

<img src="url">

It'll make it easier for people to understand your points

Abiji-2020 commented 8 months ago

Hi @Abiji-2020 , Thank you for your valuable feedback , but I'm quiet confused because Eddie said not to apply custom colors. Can you please elaborate it more like via screenshot? Thanks.

image This was the changes made by you, and the preferred colour changes in the issue is being made as image . image . by providing the hex values of the colours for foreground and background. So in my personal opinion it is better if the colours are given in the hex value

Hi @Abiji-2020. When it comes to displaying code, it's best to do them as snippets like this:

<img src="url">

It'll make it easier for people to understand your points

Thankyou @CBID2 hereafter I try to follow those

eddiejaoude commented 8 months ago

Using tailwind colours is great πŸ‘ There should be enough options without needing to create new colours as suggested by CodeRabbit

CBID2 commented 8 months ago

Yay you made your first open source contribution @itsharshitrwt! 😊

itsharshitrwt commented 8 months ago

Thankyou so much Everyone for helping me 😊 specially @CBID2 .

CBID2 commented 8 months ago

Thankyou so much Everyone for helping me 😊 specially @CBID2 .

Yup! :) I highly recommend using this website to post about contribution. Also, now that you've made your first contribution, I highly recommend checking out pizza-verse. It's one of OpenSauced's many repos that you can contribute to, and it focuses on pizza :)

itsharshitrwt commented 8 months ago

Hi Folks , I checked the reporater's website , When i opened the website first time everything looks fine but when i opened it second time i see the green color is added to links and not to the "Rated " element and also white color was not visible to the time element . I'm just concerned about it now.πŸ˜” Even though the first time i opened it everything went as expected.

Screenshot:

Screenshot 2024-02-01 141208

itsharshitrwt commented 8 months ago

Thankyou so much Everyone for helping me 😊 specially @CBID2 .

Yup! :) I highly recommend using this website to post about contribution. Also, now that you've made your first contribution, I highly recommend checking out pizza-verse. It's one of OpenSauced's many repos that you can contribute to, and it focuses on pizza :)

Thanks @CBID2 , I will surely checkout the website.

eddiejaoude commented 8 months ago

Hi Folks , I checked the reporater's website , When i opened the website first time everything looks fine but when i opened it second time i see the green color is added to links and not to the "Rated " element and also white color was not visible to the time element . I'm just concerned about it now.πŸ˜” Even though the first time i opened it everything went as expected.

I moved the colours around after merging your PR, you can check the commit history - I thought the repo url will be better to be more highlighted instead

itsharshitrwt commented 8 months ago

Hi Folks , I checked the reporater's website , When i opened the website first time everything looks fine but when i opened it second time i see the green color is added to links and not to the "Rated " element and also white color was not visible to the time element . I'm just concerned about it now.πŸ˜” Even though the first time i opened it everything went as expected.

I moved the colours around after merging your PR, you can check the commit history - I thought the repo url will be better to be more highlighted instead

Thanks Eddie for clarifying this , I got worried that I made some mistake πŸ˜….