#312: Add pagination to the `github/{id}/events` endpoint

EddieHubCommunity / api

API to manage our community data

https://api.eddiehub.io

MIT License

68 stars 63 forks source link

#312: Add pagination to the `github/{id}/events` endpoint #320

Closed pacyL2K19 closed 5 months ago

pacyL2K19 commented 6 months ago

Fixes Issue

Closes #312

Changes proposed

Added pagination feature, added a UtilsModule for shared logic, currently with a simple pagination service file, can be extended with complex shared logic in the future

Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] My change requires changes to the documentation.
[x] I have updated the documentation accordingly.
[x] All new and existing tests passed.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

pacyL2K19 commented 6 months ago

@eddiejaoude please have a look Looking forward to getting feedback from you and contributing more on the project

pacyL2K19 commented 6 months ago

Thanks for contributing!

I don't think changes to the lock file are required?

They weren't required My bad, the change came after an npm install I can revert it

pacyL2K19 commented 6 months ago

Thanks for contributing!

I don't think changes to the lock file are required?

I just checked, don't you think it's fine to let it match the version we have in the package.json file? This auto updated when I ran the install command, please let me know if I should revert this change or keep the old version @eddiejaoude

eddiejaoude commented 5 months ago

After merging the versions will be updated. Unless making changes to the package.json file, we must use npm ci so it uses the lock file and doesn't update it