EddieHubCommunity / good-first-issue-finder

Issue-Crawler for GitHub based on Sveltekit
https://finder.eddiehub.org
MIT License
528 stars 334 forks source link

bugITwhisperer: playwright skeleton tests steps update (Issue #378) #379

Closed bugITwhisperer closed 1 year ago

bugITwhisperer commented 1 year ago

Fixes Issue #378

Changes proposed

  1. This 1st skeleton does not require fixing:
    test.fixme('is the highlighted item in the left-menu is the correct one', async ({ page }) => {
    // navigate to the docs landing page /docs
    // check if the Introduction element in the left menu is holding the active class
    });

since it's already covered in the 1st test:

test('Docs header element is active', async ({ page }) => {
  // navigate to the docs landing page /docs
  await page.goto('/docs');

  // check if the docs link in the page header is having the active class
  await expect(page.getByRole('link', { name: 'Docs' })).toHaveClass(/active/);
});
  1. Same for the 2nd skeleton:

    test.fixme(
    'is the left-side menu containing an element with the same name as the page headline',
    async ({ page }) => {
    // navigate to the docs landing page /docs
    // check if the Introduction element in the left menu is holding the active class
    },
    );

    it's been covered by this test:

    test('Page Heading is correct', async ({ page }) => {
    // navigate to the docs landing page /docs
    await page.goto('/docs');
    
    // check if the heading contains Introduction
    expect(await page.textContent('h1')).toBe('Introduction');
    });
bugITwhisperer commented 1 year ago

@eddiejaoude, @Benmuiruri , @frazie , @tbhaxor: hi there! could you have a look at my suggested changes? :)

bugITwhisperer commented 1 year ago

@Cahllagerfeld : can you add hacktoberfest and/or hacktoberfest-accepted labels before merging this PR?

eddiejaoude commented 1 year ago

can you add hacktoberfest and/or hacktoberfest-accepted labels before merging this PR?

I have added the label hacktoberfest-accepted (but it is not required because the whole repo has the topic hacktoberfest)

Great collab 💪