EddieHubCommunity / good-first-issue-finder

Issue-Crawler for GitHub based on Sveltekit
https://finder.eddiehub.org
MIT License
528 stars 334 forks source link

[FEATURE] Login Button should be hover like Get started Button #385

Closed pragyamishra56 closed 1 year ago

pragyamishra56 commented 1 year ago

Description

Issue Type: Feature Request

Problem: Currently, the hover effect on the Login Button does not provide a visually appealing and engaging user experience. It lacks the user-friendly and inviting interaction that the Get Started Button offers.

Screenshots

Screenshot 2023-10-08 145810 Screenshot 2023-10-08 145833

Additional information

Improved user experience: A consistent hover effect across the platform enhances the overall user experience and encourages user engagement.

Implementation Steps:

Identify the existing CSS styles for the Login Button's hover effect. Analyze the CSS styles for the Get Started Button's hover effect. Modify the Login Button's CSS styles to match the Get Started Button's hover effect. Test the updated hover effect to ensure it provides a visually appealing and engaging experience. Verify the change does not introduce any negative side effects or compatibility issues.

pragyamishra56 commented 1 year ago

I hope you're doing well. I'm Pragya Mishra, working as a Front-end developer and I'm excited about this project. This would be my first time Hactoberfest2023 contribution to an open-source project, and I'm eager to get started. I've been looking through the issues and I'm particularly drawn to this issue. It seems like a great start for me to learn and contribute to this project. Could I take on this issue? I'm more than willing to put in the effort and would greatly appreciate your guidance on how to proceed. Thanks a lot for your time and consideration!

Cahllagerfeld commented 1 year ago

Sure 👍

pragyamishra56 commented 1 year ago

@Cahllagerfeld Thank you so much Sir it means a lot to me

pragyamishra56 commented 1 year ago

@Cahllagerfeld Sir, could you assist me in finding the 'index.html' file? I've searched many times.

Cahllagerfeld commented 1 year ago

The login button is living in the following file src/lib/components/header.svelte

pragyamishra56 commented 1 year ago

@Cahllagerfeld Sir, could you please assist me like when I make changes , I need guidance on how to view the main page of the project. Can you please specify where I can find this page and how to preview it during the process? Currently, I encounter a blank page issue

AmineAouragh commented 1 year ago

hey Pragya could you fix the issue? I am talking about your blank page issue.

I think that after cloning your fork locally and making sure that you have the necessary dependencies installed on your computer a simple "npm run dev" could get you started. Although i never wrote svelte code but i looked on google and found out that npm run dev is how you preview your svelte project on your localhost like with react

Radhikarathi04 commented 1 year ago

Hello! This marks my first foray into open source contributions. I initially inquired whether I could contribute to this issue, and I wasn't certain if I needed to wait for it to be assigned to me. Nevertheless, I took the initiative to make the necessary changes, updated the source code, and submitted a PR.

AmineAouragh commented 1 year ago

Hey Radhika!

Could you preview the project and see if the issue wasn't already fixed?

Cahllagerfeld commented 1 year ago

Thank you for jumping in @AmineAouragh. Yes indeed, after cloning the repo, you need to run npm install and npm run dev afterwards to get started with the development server 👍

@Radhikarathi04 As this issue is assigned to @pragyamishra56, I'd want to wait if she opens a PR, so we can get it merged, otherwise I'm happy to pick yours 👍

Radhikarathi04 commented 1 year ago

Hey Radhika!

Could you preview the project and see if the issue wasn't already fixed?

I previewed the project, the issue isn't fixed.

Radhikarathi04 commented 1 year ago

Thank you for jumping in @AmineAouragh. Yes indeed, after cloning the repo, you need to run npm install and npm run dev afterwards to get started with the development server 👍

@Radhikarathi04 As this issue is assigned to @pragyamishra56, I'd want to wait if she opens a PR, so we can get it merged, otherwise I'm happy to pick yours 👍

Thank you @Cahllagerfeld

pragyamishra56 commented 1 year ago

@Radhikarathi04 @Cahllagerfeld Sorry for being late, ma'am and Sir. Could you please give me some time? I'll fix this issue

pragyamishra56 commented 1 year ago

@Cahllagerfeld Sir, I'm done. If any further issues arise, please let me know if there are any more changes or improvements to be made