search

EddieHubCommunity / good-first-issue-finder

Issue-Crawler for GitHub based on Sveltekit
https://finder.eddiehub.org
MIT License
528 stars 334 forks source link

Prettier husky #415

Open Bashamega opened 3 months ago

Bashamega commented 3 months ago

Hello:)

I have integrated prettier in husky

Bashamega commented 3 months ago

Hello @eddiejaoude :) Can you please merge this pr

eddiejaoude commented 3 months ago

Hello @eddiejaoude :) Can you please merge this pr

Do you mean "review this PR"? BTW the extra notifications are not required

@Cahllagerfeld are you able to review?

Bashamega commented 3 months ago

the extra notifications is not required

Sorry for the notification

eddiejaoude commented 3 months ago

thank you for understanding 👍

Bashamega commented 3 months ago

Thank you. Please exclude CHANGELOG.md file as this is autogenerated and will cause conflicts

It should be excluded because of the prettier ignore.

eddiejaoude commented 3 months ago

Thank you. Please exclude CHANGELOG.md file as this is autogenerated and will cause conflicts

It should be excluded because of the prettier ignore.

Oh strange, there are changes to the file https://github.com/EddieHubCommunity/good-first-issue-finder/pull/415/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed

eddiejaoude commented 3 months ago

Strange why the ignore file is not being used, here are the official docs and the filename is correct https://prettier.io/docs/en/ignore.html

Bashamega commented 3 months ago

Strange why the ignore file is not being used, here are the official docs and the filename is correct https://prettier.io/docs/en/ignore.html

Is it because we are using husky? I don't know how to fix it

eddiejaoude commented 3 months ago

Is it because we are using husky? I don't know how to fix it

I don't think they are related or causing any issues. I see you have joined EddieHub Discord, let's continue the chat there and publish the conclusion here afterwards

Bashamega commented 3 months ago

Hello:)

I have fixed the issue. The issue was that instead of specifying .prettierignore we were specifying the .gitignore. I have now fixed it.