EddieHubCommunity / support

Community Help & Support and AEA (Ask Everyone Anything)

https://eddiehubcommunity.github.io/support/

MIT License

342 stars 159 forks source link

[REVIEW] ShreyaPrasad1209 #2017

Closed ShreyaPrasad1209 closed 2 years ago

ShreyaPrasad1209 commented 3 years ago

GitHub Profile Link: https://github.com/ShreyaPrasad1209

github-actions[bot] commented 3 years ago

It's great having you contribute to this project

Welcome to the community :nerd_face:

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord Server and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

kaiwalyakoparkar commented 3 years ago

Hey @ShreyaPrasad1209, thanks for sharing. These are suggestions from my side

The octocat gifs looks good
Maybe increase font size of the about section
You can remove the profile visitors tag as it can be manipulated easily
You can place github stats and streak cards side by side to optimize the space
You can remove the stats below the streak as it can be easily found out through your profile
Loved the gif at the end

schmelto commented 3 years ago

Wow I really like your profile! Agree with @kaiwalyakoparkar s points. Maybe also consider making some line breaks into the first section where you write some words about yourself.

ShreyaPrasad1209 commented 3 years ago

@schmelto @kaiwalyakoparkar thank you for your reviews! I will surely take these suggestions into account ❤️

Panquesito7 commented 3 years ago

Amazing profile, @ShreyaPrasad1209! Everything looks great, except for some minor stuff. I have made a pull request in your repository to fix that. Thank you! 😄

ShreyaPrasad1209 commented 3 years ago

@kaiwalyakoparkar @schmelto @Panquesito7 I have included your changes, please take a look 👀

kaiwalyakoparkar commented 3 years ago

@ShreyaPrasad1209 that looks need. Final suggestion from my side which I mentioned earlier. You can place your GitHub stats and GitHub streak cards one beside the other. For reference take a look at my profile. I have used the same cards and placed them togather.

Panquesito7 commented 3 years ago

I have included your changes. Please take a look.

All looks perfect! Great work, and thank you for sharing your profile with us! 😄:+1: If you want to keep contributing to EddieHub, don't forget to join the community! 🙂

eddiejaoude commented 3 years ago

Thank you for sharing, we will review on a live stream soon 👍

ShreyaPrasad1209 commented 3 years ago

@Panquesito7 thanks for the invite! I have already joined EddieHub 🚀

FayasNoushad commented 3 years ago

GitHub Campus Expert :fire:

FayasNoushad commented 3 years ago

GitHub Campus Expert

Nice 👍

eddiejaoude commented 2 years ago

Looks great, some thoughts

Both headings have underline, suggestion removing the 2nd underline
Try to use the blank space on the right of the widgets, so that the page is not so long