EddieHubCommunity / support

Community Help & Support and AEA (Ask Everyone Anything)
https://eddiehubcommunity.github.io/support/
MIT License
342 stars 159 forks source link

[REVIEW] mohitmishra786 #2340

Closed mohitmishra786 closed 2 years ago

mohitmishra786 commented 3 years ago

GitHub Profile Link

https://github.com/mohitmishra786

github-actions[bot] commented 3 years ago

It's great having you contribute to this project

Welcome to the community :nerd_face:

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord Server and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

FayasNoushad commented 3 years ago

Nice 👍

mohitmishra786 commented 3 years ago

If i can work on something to improve my profile do let me know, i am always ready to learn new stuffs.

FayasNoushad commented 3 years ago

Please merge this pull request.

FayasNoushad commented 3 years ago

Use this:

schmelto commented 3 years ago

Maybe take a look at the failing github action otherwise I like your profile

Panquesito7 commented 3 years ago

Apart from what @FayasNoushad and @schmelto said, everything is looking great! 😄👍

mohitmishra786 commented 3 years ago

Maybe take a look at the failing GitHub action otherwise I like your profile

actually, I am not able to understand why they are falling , can you help me out with that

Panquesito7 commented 3 years ago

Maybe take a look at the failing GitHub action otherwise I like your profile

actually, I am not able to understand why they are falling, can you help me out with that

I think you should remove that action; it is not needed. 🙂

mohitmishra786 commented 3 years ago

Maybe take a look at the failing GitHub action otherwise I like your profile

actually, I am not able to understand why they are falling, can you help me out with that

I think you should remove that action; it is not needed. 🙂

i also don't knew how to remove them

Panquesito7 commented 3 years ago

i also don't knew how to remove them

Made a pull request to fix that. 🙂

mohitmishra786 commented 3 years ago

i also don't knew how to remove them

Made a pull request to fix that. 🙂

Thanks, I do have merged it but can you tell me that what does it mean , I mean after merging if I will make any changes will it not go inside workflow run

Panquesito7 commented 3 years ago

i also don't knew how to remove them

Made a pull request to fix that. 🙂

Thanks, I do have merged it but can you tell me that what does it mean , I mean after merging if I will make any changes will it not go inside workflow run

After merging, the workflow should be gone and my changes would be implemented now. 🙂

shehan-kv commented 3 years ago

It looks cool

eddiejaoude commented 2 years ago

Looks greats 👍 Reviewed on live stream https://www.youtube.com/watch?v=KnR5OoVLpc4

Some suggestions