search

EddieLa / JOB

A Barcode scanner capapable of reading Code128, Code93, Code39, Standard/Industrial 2 of 5, Interleaved 2 of 5, Codabar and EAN-13 barcodes in javascript.
http://eddiela.github.io/JOB
600 stars 204 forks source link

Code128 discrepancy #51

Open sceline opened 7 years ago

sceline commented 7 years ago

Hi,

We are using this library for image capture and works almost very good except for code 128 barcodes not being scanned properly. If you can check it , it would be of great help so that we can test it again and push the code to prod.

The decoding fails for code128 in the demo page too. http://eddiela.github.io/JOB/

Also the live streaming demo isnt scanning any barcodes. Also when the demo is tried on mobile it opens the front camera only.

Thanks!

karan-kang commented 6 years ago

Facing the same issue

JenJieJu commented 4 years ago

Hi,

We are using this library for image capture and works almost very good except for code 128 barcodes not being scanned properly. If you can check it , it would be of great help so that we can test it again and push the code to prod.

The decoding fails for code128 in the demo page too. http://eddiela.github.io/JOB/

Also the live streaming demo isnt scanning any barcodes. Also when the demo is tried on mobile it opens the front camera only.

Thanks!

DecoderWorker.js line 928

Add this code after line 928

// 928
// Filtering NaN
binaryString = binaryString.filter(i => i.some(j => !isNaN(j)))
// 929