EddieTheCubeHead / Scrimbot-2.0

1 stars 0 forks source link

Refactor db sessions to be tied to ctx #26

Closed EddieTheCubeHead closed 2 years ago

EddieTheCubeHead commented 2 years ago

Currently lazy loading inside bot operations is not possible due to the way sessions are used. Tie sessions to ctx to enable lazy loading usage. Blocks #3 currently

EddieTheCubeHead commented 2 years ago

Tryout revealed this to do far more bad than good for the architecture basically exposing all of the codebase to sqlalchemy schenanigans. Yes you can lazy load but it's not worth the mess in code.