Closed RaffaeleMorganti closed 5 years ago
Thanks for making the commits tidy. I'm reviewing the changes piece by piece.
As you see in current master branch, there are 2 builds now: "modern" and "classic". I will compare your PR with classic build, then implement them in modern build if appropriate. Considering some highlightings are not good for common users, I will drop those changes. Will explain why :)
Please be notice that it may mess up your current codes, please git checkout -b
your repo. Rebase it or maintain your version later.
Script files:
build.sh
: Apply, then merge to latest that is more descriptive, commit: 2bbe755ac610483a4199f2d95519015c96c8fdf9build.ps1
: Revert. Remove since there will be more true
and false
implementations, or even switch another template engine for if-then features.Settings in Template XML:
---
as normal text in their article. I also saw this in some URLs. That's why Keywords 2 requires 4 dashes for both <h2>
and <hr>
.false
by default.It is deducted by 0.1 and 0.2.
?\~ \< \>
: Apply. Good take!\
: Revert back to \\
. Single \
is confusing in normal text-based article. (Or did I miss something?) #todo: |:
Change to :|: |: :| \| |
. :
alone is confusing in normal text-based article.~~~
Apply.>
: Revert. (1) The character >
is quite common and lot of users don't escape it in their article. UDL is not powerful enough to correctly identify it as <quote>
. (2) More importantly, a quote is powerful and important. It should not be grey out. And should contain the styles inside the quote. (3) It should be something like "comment line style", but headings are more common in writing. So I made a choice._
and ___
: Revert. Does not pass link test, e.g. [bookmark]: /rare___link.html "It just happens"
((EOL)) things
: Apply.((EOL))
.: Revert.** It is solved in modern build, e.g.
bullet point with bold text* is messed. For
~~`, I will find a better style. Next time please.
Build
Theme