search

EddyRivasLab / easel

Sequence analysis library used by Eddy/Rivas lab code
Other
46 stars 26 forks source link

esl_fprintf and similar functions #41

Closed horta closed 3 years ago

horta commented 5 years ago

I like the idea of having fprintf/printf etc. alternatives that does the error checking on the spot. This is IMHO the proper approach when there is nothing that the caller can do when that kind of error happens.

However, the current implementation has a flaw: the call to ESL_EXCEPTION_SYS macro will record the same __FILE__ and __LINE__ (ESL_EXCEPTION_SYS) everywhere esl_printf is being used.

Shall we propose MACRO replacement for those functions?

cryptogenomicon commented 5 years ago

Yes, that sounds like a better idea. (Not a high priority though.)