search

EddyRivasLab / hmmer

HMMER: biological sequence analysis using profile HMMs
http://hmmer.org
Other
305 stars 69 forks source link

Add CI based on Github Actions #286

Closed julien-faye closed 1 year ago

julien-faye commented 1 year ago

The build of develop branch seems to be broken at the moment:

...
CC create-profmark.o
CC rocplot.o
create-profmark.c:28:10: fatal error: esl_msa_iset.h: No such file or directory
   28 | #include "esl_msa_iset.h"
      |          ^~~~~~~~~~~~~~~~
...

I think the project would benefit of a CI system! Github Actions is free for public repositories and it requires low maintenance. It tests develop branch on Ubuntu 20.04 x86_64 and aarch64

julien-faye commented 1 year ago

CI results could be seen on my fork: https://github.com/julien-faye/hmmer/actions/runs/3204064857

cryptogenomicon commented 1 year ago

Yes, we know, thanks!

julien-faye commented 1 year ago

Welcome, @cryptogenomicon !

It seems you are not interested in having a CI system to prevent such regressions ?

martin-g commented 1 year ago

@julien-faye This PR is nice! Unfortunately the project team does not find CI systems useful - https://github.com/EddyRivasLab/hmmer/pull/233#issuecomment-1103908220

npcarter commented 1 year ago

Expanding a bit: I believe we already use a Travis CI system to auto-run our regression suite. With our small team (2 people), so can mostly just talk when problems occur. The current issue with Easel's develop branch not building is a rare problem that we're working around due to Sean's challenges finding time to code while being department chair.

-Nick

On Fri, Oct 7, 2022 at 9:13 AM Martin Grigorov @.***> wrote:

@julien-faye https://github.com/julien-faye This PR is nice! Unfortunately the project team does not find CI systems useful - #233 (comment) https://github.com/EddyRivasLab/hmmer/pull/233#issuecomment-1103908220

— Reply to this email directly, view it on GitHub https://github.com/EddyRivasLab/hmmer/pull/286#issuecomment-1271576179, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABDJBZHEVUXD2CWFBIIMEYTWCAOWLANCNFSM6AAAAAAQ7PGCX4 . You are receiving this because you are subscribed to this thread.Message ID: @.***>

julien-faye commented 1 year ago

@npcarter All is fine! I understand!

But I think TravisCI is not in use at the moment - https://app.travis-ci.com/github/EddyRivasLab/hmmer Maybe it was used with travis-ci.org in the past, but Travis-CI people decommissioned .org almost 3 years ago and asked all projects to move to .com.

I will not delete the branch in my fork. If you ever decide to use Github Actions you could reopen this PR and merge it!