search

EddyRivasLab / hmmer

HMMER: biological sequence analysis using profile HMMs
http://hmmer.org
Other
305 stars 69 forks source link

Fix `p7_tophits_Threshold` not resetting domain counts #307

Closed althonos closed 1 year ago

althonos commented 1 year ago

Hi !

In althonos/pyhmmer#46 @zdk123 found out that p7_tophits_Threshold is not resetting domain counts, which may cause issues if the function is called more than once. I don't think it happens in HMMER, but it may happen in PyHMMER.

npcarter commented 1 year ago

Hello. Turns out that we'd made this exact change in one of our feature branches but hadn't merged into develop, so we're going to accept this PR.

zdk123 commented 1 year ago

Thanks!