EddyRivasLab / hmmer

HMMER: biological sequence analysis using profile HMMs
http://hmmer.org
Other
317 stars 70 forks source link

stotrace unit test may fail on i686 platforms #73

Closed traviswheeler closed 7 years ago

traviswheeler commented 7 years ago

ID h63 TITLE stotrace unit test may fail on i686 platforms AFFECTS 3.0b2 and earlier FIXED_IN 3.0b3 STATUS CLOSED XREF - REPORTED_BY Serdar Dalgic dalgic.srdr@gmail.com OPENED_DATE SRE, Fri Oct 30 10:39:00 2009 CLOSED_DATE SRE, Fri Oct 30 10:39:02 2009 DESCRIPTION
"make check" shows a stotrace unit test failure. Does not occur on x86_64, but reproduced on cf-debian, one of our i686 platforms. Issue is a harmless floating point comparison; gets (sc > vsc) when really (sc == vsc). That is, the sampled trace is identical to the Viterbi optimal path, but due to floating point roundoff, the score of the sampled trace is a teensy bit more than the Viterbi score, and this triggers test failure. Fixed by adding some slop/tolerance to the test.