search

EddyVerbruggen / HeadsetDetection-PhoneGap-Plugin

:headphones: A PhoneGap plugin for detection of a headset (wired or bluetooth)
34 stars 27 forks source link

Support event based detection and updated to new cordova plugin clobbers #5

Closed gerhardsletten closed 8 years ago

gerhardsletten commented 8 years ago

In a project we needed to know it the headset was attached or removed while playing, so added support for that as well. Also updated to new cordova standard plugin, as they should be available just below the window object, see #2

EddyVerbruggen commented 8 years ago

Oh wow, that's very cool, thanks so much for this!

I will merge it soon and rename headsetRemove to headsetRemoved to make it more consistent with headsetAdded, but that's it really.

EddyVerbruggen commented 8 years ago

Hey @gerhardsletten, I've merged and tweaked your PR. It works perfectly, thanks! 👍

Note that on iOS 10 beta 1 it doesn't work but that can be said for a lot of things, I'm sure support will be better in beta's to come.

I've added you as committer to the repo, so if you see anything that can be fixed in the future just go right ahead.

gerhardsletten commented 8 years ago

@EddyVerbruggen Great, nice to help out. yes. iOS 10 will probably be out in september with the autumn keynote, so that might be stuff still in work there. Guess there is no point supporting a pre-release?

EddyVerbruggen commented 8 years ago

Nah, I've found that stuff like push notifications and badges are also messed up. But just got word beta 2 will be available tomorrow-ish, so let's hope it's a bit better.

I won't fix anything before the first public beta (nr 3) which is due in about 30 days.