search

EddyVerbruggen / HealthKit

Cordova plugin for the iOS HealthKit framework
MIT License
168 stars 216 forks source link

dynamically add healthkit entitlements #83

Closed johnborges closed 7 years ago

johnborges commented 7 years ago

As of cordova-ios@4.3.0 you can make direct use of a debug and release entitlement plist to dynamically add entitlements. No need for hooks. This plugin can directly add the entitlements it needs. https://github.com/Telerik-Verified-Plugins/HealthKit/issues/79

johnborges commented 7 years ago

So it looks like on older projects which make use of cordova-ios<4.3.0 the plugin works fine and simply ignores the references made to Entitlements-Debug and Entitlements-Release. No need to enforce cordova-ios@4.3.0 requirement.

EddyVerbruggen commented 7 years ago

That's perfect! I guess we're ready to merge then, right?

johnborges commented 7 years ago

yup

EddyVerbruggen commented 7 years ago

Awesomness, will release to npm soon 🎉