search

EddyVerbruggen / HealthKit

Cordova plugin for the iOS HealthKit framework
MIT License
168 stars 220 forks source link

Check for valid metadata on quantitySample to avoid crash from bad metadata from Withings blood pressure sample #89

Closed sgilroy closed 7 years ago

sgilroy commented 7 years ago

This addresses the crash described in https://github.com/Telerik-Verified-Plugins/HealthKit/issues/87

Smoke Test

  1. Install "Health Mate" from Withings
  2. Login and add a blood pressure measurement (measurement can be added manually or from Withings blood pressure cuff)
  3. Sync the measurement from Health Mate to the Apple Health app (HealthKit)
  4. Query for blood pressure from an app using the https://github.com/Telerik-Verified-Plugins/HealthKit
mikeg0184 commented 7 years ago

Any chance we can get this merged in?

EddyVerbruggen commented 7 years ago

Sure, it looks good to me, thanks @sgilroy -- I missed this PR for some reason, so thx @mgerstenblatt for pinging me. 👍

mikeg0184 commented 7 years ago

thanks @EddyVerbruggen! will you be bumping the version too?

EddyVerbruggen commented 7 years ago

Done. 0.5.4 is on npm.