EddyVerbruggen / SocialSharing-PhoneGap-Plugin

👨‍❤️‍💋‍👨 Cordova plugin to share text, a file (image/PDF/..), or a URL (or all three) via the native sharing widget
MIT License
1.78k stars 908 forks source link

the socialsharing plugin in my app is kinda slow to show the popup tabs #1091

Open HaziqYeon opened 4 years ago

HaziqYeon commented 4 years ago

Im creating an app that has a sharing function, but its pretty slow to show the actual share popup, ive tried sending url link to the image and a base64 version of the image, but I don't see the difference in performance speed. Is there something wrong with my code. I don't know if I have to show the code or not, if I do please tell me and I'll upload the social sharing part

Boby commented 4 years ago

you should check on the process, but I tested the share is pretty fast itself with text based trigger :)

HaziqYeon commented 4 years ago

@Boby ahh okk ill try and change a few things and ill update the thread in a bit

Boby commented 4 years ago

the base64 could be the issue but you can test and strip off the base64 and try text 1st see how it goes

HaziqYeon commented 4 years ago

does the internet factor into the popup speed?, Ive tried text only, base64img and url and now they're fast. everytime i make a change I made a new build for the ionic app, now its fast even with the base64img, i dont know what happened but I guess this is ok. If you have anymore suggestions just incase, pls reply to this thread. I think ill keep this thread open for a few more hours.

khazaddoom commented 4 years ago

Im creating an app that has a sharing function, but its pretty slow to show the actual share popup, ive tried sending url link to the image and a base64 version of the image, but I don't see the difference in performance speed. Is there something wrong with my code. I don't know if I have to show the code or not, if I do please tell me and I'll upload the social sharing part

Check this Pull Request https://github.com/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/pull/1090