EddyVerbruggen / SocialSharing-PhoneGap-Plugin

👨‍❤️‍💋‍👨 Cordova plugin to share text, a file (image/PDF/..), or a URL (or all three) via the native sharing widget
MIT License
1.77k stars 909 forks source link

Plugin compatibility with WKWebView? #1098

Open joaolori opened 4 years ago

joaolori commented 4 years ago

Hello,

Is this plugin compatible with the new WKWebView webview engine?

Related with this: https://github.com/ionic-team/cordova-plugin-ionic-webview/issues/559

Thanks

tlacroix commented 4 years ago

Hi @joaolori,

I was asking myself the same question, and I found the answer below. https://github.com/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/issues/1052

Short: it's been removed in 5.6.0+. If you look at the code, you will see that the block is commented out. Pretty sure that's enough for ITMS-90809.

- (NSString*)getIPadPopupCoordinates {
  // see https://github.com/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/issues/1052
  return nil;
  /*
  if (_popupCoordinates != nil) {
    return _popupCoordinates;
  }
  if ([self.webView respondsToSelector:@selector(stringByEvaluatingJavaScriptFromString:)]) {
    return [(UIWebView*)self.webView stringByEvaluatingJavaScriptFromString:@"window.plugins.socialsharing.iPadPopupCoordinates();"];
  } else {
    // prolly a wkwebview, ignoring for now
    return nil;
  }
  */
}
EinfachHans commented 4 years ago

I use this Plugin and have no Warning about ITMS-90809

tanzanman commented 4 years ago

Yes! I can confirm successful submission of an app today using this plugin at version 5.6.8. App uses WKWebview only along with this plugin and passed. It's really frustrating now that Apple no longer accepts app submissions if their code scanners sniff ITMS-90809 and you have to upload the binary to find that out. Thanks Eddy for your contributions here!