EddyVerbruggen / SocialSharing-PhoneGap-Plugin

👨‍❤️‍💋‍👨 Cordova plugin to share text, a file (image/PDF/..), or a URL (or all three) via the native sharing widget
MIT License
1.78k stars 906 forks source link

Fix conflicting provider on android #752

Closed onlydave closed 7 years ago

onlydave commented 7 years ago

android:authorities need to be unique across all apps installed on your android device.

Installing a second app with this plugin will fail as they'll both try and use the com.socialsharing.provider provider.

Using the package name + sharing.provider means this should be unique to app and plugin

onlydave commented 7 years ago

750

onlydave commented 7 years ago

749

onlydave commented 7 years ago

744, #745, #740

onlydave commented 7 years ago

Not sure what android:authorities should be.

Options could be:

Just using $PACKAGE_NAME.provider might still conflict with other plugins that have the same idea.

I've tested all of the above on a nexus 5x and will be pushing a nightly to our QA team today with $PACKAGE_NAME.socialsharing.provider in it for testing.

740, #744, #745, #749, #750

EddyVerbruggen commented 7 years ago

Your code looks good to me - do you want me to wait a bit before merging?

onlydave commented 7 years ago

@EddyVerbruggen merge away

EddyVerbruggen commented 7 years ago

Sweet! I'll tag a release shortly.

EddyVerbruggen commented 7 years ago

@onlydave can you take a look at why #753 isn't an issue in your case? Do you have other plugins installed using the support library perhaps?

onlydave commented 7 years ago

@EddyVerbruggen I think it's probably because i have Android Support Repository installed from the android SDK Manager

EddyVerbruggen commented 7 years ago

@onlydave Could also be because you have fi the Camera plugin installed as well.

Anyway, I've now added a framework reference to the v4 support library so folk using PhoneGap Build can use the plugin again.

onlydave commented 7 years ago

@EddyVerbruggen no camera plugin but could be a different one. Thanks