Image sharing does not work well when URL has special characters like %2F - Githubissues

EddyVerbruggen / SocialSharing-PhoneGap-Plugin

👨‍❤️‍💋‍👨 Cordova plugin to share text, a file (image/PDF/..), or a URL (or all three) via the native sharing widget

MIT License

1.78k stars 908 forks source link

Image sharing does not work well when URL has special characters like %2F #838

Open royken opened 7 years ago

royken commented 7 years ago

Hello, Thank you for this great plugin. It is very wonderful. But i noticed that it does not encode url. For example %2F is not replaced by /. The result is that when my image url has %2F it says file is wrong. Bellow are two url files used for test. URL 1 : https://firebasestorage.googleapis.com/v0/b/bracongo-marketing.appspot.com/o/images%2F20x6saxo.jpg?alt=media&token=1a8b17cb-9fa5-4fb6-b8d5-4d16daeb1bc9 URL 2 : https://firebasestorage.googleapis.com/v0/b/bracongo-marketing.appspot.com/o/sansa-snowcastle4.jpg?alt=media&token=fc79bb12-f11e-477d-878b-e4176853260b

It works well with URL 2 but fails with URL 1

EddyVerbruggen commented 7 years ago

Can you do a PR to fix it perhaps?