EddyVerbruggen / cordova-plugin-actionsheet

:clipboard: ActionSheet plugin for Cordova iOS and Android apps
208 stars 71 forks source link

Wndows Universal a suport - need to do the wiring from config.xml #28

Closed Pavel-Durov closed 8 years ago

Pavel-Durov commented 8 years ago

I've followed the logic of your wp8 platforms implementation. I've added the UWP ("windwos") platform: In order to show WinJs flyout I needed to inject an object to the document's body and afterward I could manipulate it accordingly to sent parameters.

EddyVerbruggen commented 8 years ago

That's very cool, thanks for taking the time implementing this!

Don't you need to add some bits to plugin.xml to make this work though?

Pavel-Durov commented 8 years ago

Yes you are right, I've just encounter some issues with plugin.xml configurations - I've posted it on stackoverflow : http://stackoverflow.com/questions/33472478/cordova-plugin-config-xml-uwp-windows-platformid.

Pavel-Durov commented 8 years ago

I've made a push with the config.xml changes...

EddyVerbruggen commented 8 years ago

Supernice, @Pavel-Durov!

I've made you a collaborator on the repo, so if you even need to change anything (especially for windows suppor) then feel free to go right ahead!

Pavel-Durov commented 8 years ago

Thanks! I think I've just got a clue on how to solve the config.xml issue :).