search

EddyVerbruggen / cordova-plugin-actionsheet

:clipboard: ActionSheet plugin for Cordova iOS and Android apps
208 stars 72 forks source link

First implementation of Android component #4

Closed bpappin closed 10 years ago

bpappin commented 10 years ago

This works as far as I've tested so far. Over the next while I'll be running it though some more paces. The main interface change is that I've added a new options property: androidEnableCancelButton: [true|false](default to false) because android doesn't usually use a cancel button in this case.

One thin android does do in this case is add icons to the list items, so I'll explore that later. See the example below. screenshot_2014-07-25-16-39-21

EddyVerbruggen commented 10 years ago

Cool! I will be reviewing and merging this next week because of a little vacation. Thanks for your efforts so far.

bpappin commented 10 years ago

may do a little cleanup, but I'll just tack them onto the pull request.

EddyVerbruggen commented 10 years ago

Love it! Great work @bpappin :)

EddyVerbruggen commented 10 years ago

Hi Brill, gave it some extra love (documentation mostly) and submitted the new version with Android support (1.0.0) to PhoneGap Build.

bpappin commented 10 years ago

Nice. I'll move our plugin pointer back to the main project then :)

EddyVerbruggen commented 10 years ago

Excellent. Sry for getting your name wrong all the time ;)

bpappin commented 10 years ago

hehe. I'm not offended, you're not the first, and won't be the last :)

joestump commented 10 years ago

:tada: :cake: to @bpappin – many thanks from the folks at @quickleft!

EddyVerbruggen commented 10 years ago

@joestump nice touch :+1: