search

EddyVerbruggen / cordova-plugin-actionsheet

:clipboard: ActionSheet plugin for Cordova iOS and Android apps
208 stars 71 forks source link

Added support for Cordova Android 7 (patch) #65

Open nprail opened 6 years ago

nprail commented 6 years ago

Cordova Android 7.0.0 changed the file structure which breaks this plugin. This PR fixes that.

https://cordova.apache.org/announcements/2017/12/04/cordova-android-7.0.0.html

EddyVerbruggen commented 6 years ago

Hi, thanks! is this change backward compatible with version < 7?

nprail commented 6 years ago

Unfortunately, I don't believe it is. I guess that would cause problems since not everyone is on 7. I've actually had to downgrade back to 6 due to lack of support for 7, though. I'm not sure what the best way to handle this would be.

EddyVerbruggen commented 6 years ago

Could you try having both the old and new approach in config.xml? So add the new line of code, and leave the current one intact. Perhaps Cordova accepts this..