search

EddyVerbruggen / cordova-plugin-googleplus

:heavy_plus_sign: Cordova plugin to login with Google Sign-In on iOS and Android
566 stars 627 forks source link

cordova-android@7.0.0 support #468

Open steveetm opened 6 years ago

steveetm commented 6 years ago

Can't install this plugin into android 7.0.0 platform. Any plan or in-progress work on this or PR welcome?

EddyVerbruggen commented 6 years ago

I don't know if someone has it in the works, but it's more than welcome. Especially if it's backward compatible with older Cordova versions.

steveetm commented 6 years ago

Uhh, really sorry about this false report, but turned out that the root cause is another plugin. But can't really decide who to blame, because cordova checks if a platform directory eclipse or android studio project and use AndroidManifes.xml or app/src/main/AndroidManifest.xml accordingly. If any plugin creates a lib/ directory, then it will be treated as an eclipse project, and plugin installs after that will fail, doh. Reordering the plugin installs seems to fix everything, just put the legacy ones which installs lib/ directory to the last.

erperejildo commented 6 years ago

I'm using this version and it works locally (but not on prod): https://github.com/EddyVerbruggen/cordova-plugin-googleplus/issues/471

akhatri commented 6 years ago

+1 I can't install cordova-android@7.1.0 and cordova@8.0 It fails to add the platform. I'm not sure if it's this plugin but it looks to be as it fails when it installs. capture google plus

Cordova plugins list branch-cordova-sdk 2.6.24 "branch-cordova-sdk" cordova-clipboard 1.1.1 "Clipboard" cordova-plugin-add-swift-support 1.7.2 "AddSwiftSupport" cordova-plugin-advanced-http 1.5.6 "Advanced HTTP plugin" cordova-plugin-app-version 0.1.9 "AppVersion" cordova-plugin-appavailability 0.4.2 "AppAvailability" cordova-plugin-badge 0.8.7 "Badge" cordova-plugin-camera 4.0.2 "Camera" cordova-plugin-customurlscheme 4.3.0 "Custom URL scheme" cordova-plugin-device 2.0.1 "Device" cordova-plugin-file 6.0.1 "File" cordova-plugin-fingerprint-aio 1.3.4 "FingerprintAllInOne" cordova-plugin-googleplus 5.2.3 "Google SignIn" cordova-plugin-inappbrowser 2.0.2 "InAppBrowser" cordova-plugin-intercom 5.0.0 "Intercom" cordova-plugin-media-capture 3.0.1 "Capture" cordova-plugin-mixpanel 4.2.0 "Mixpanel" cordova-plugin-nativestorage 2.3.1 "NativeStorage" cordova-plugin-splashscreen 5.0.2 "Splashscreen" cordova-plugin-statusbar 2.4.1 "StatusBar" cordova-plugin-whitelist 1.3.3 "Whitelist" cordova-plugin-x-socialsharing 5.3.2 "SocialSharing"

akhatri commented 6 years ago

UPDATE - Apologies but it also appears to be another plugin's fault 😀 I had to remove all my plugins one by one until I found the cause was cordova-plugin-fingerprint-aio. Basically a quick test is to check if the has any asset references which breaks the cordova build on the latest version. It should use

This thread offers more detail https://forums.adobe.com/thread/2445961