search

EddyVerbruggen / cordova-plugin-native-keyboard

:musical_keyboard: Add a Slack / WhatsApp - style chat keyboard to your Cordova app!
274 stars 66 forks source link

add plugin with license to project fails #92

Open pcvengros opened 5 years ago

pcvengros commented 5 years ago

cordova-android 7.1.2 cordova 8.1.2

without android platform added to project I have added keyboard plugin with license after that I have added android platform: cordova platform add android

result: Installing "cordova-plugin-native-keyboard" for android Error during processing of action! Attempting to revert... Failed to install 'cordova-plugin-native-keyboard': TypeError [ERR_INVALID_ARG_TYPE]: Uh oh! The "path" argument must be of type string. Received type undefined at assertPath (path.js:39:11) at Object.resolve (path.js:1088:7)

pcvengros commented 5 years ago

workaround for now - add plugin to project without license - do search&replace for word "TRIAL" and replace it with License number :)...

pcvengros commented 5 years ago

please see my PR: https://github.com/EddyVerbruggen/cordova-plugin-native-keyboard/pull/94

dmastag commented 5 years ago

I tried using your PR by doing cordova plugin add https://github.com/securCom/cordova-plugin-native-keyboard.git

And then running cordova platform add android@7.1.2

But I am still getting the following

Error during processing of action! Attempting to revert...
Failed to install 'cordova-plugin-native-keyboard': TypeError [ERR_INVALID_ARG_TYPE]: Uh oh!
The "path" argument must be of type string. Received type undefined
    at validateString (internal/validators.js:125:11)
    at Object.resolve (path.js:161:7)

It looks like it works if using cordova-android 7.1.4 but I have this problem in it that prevents me to update https://github.com/apache/cordova-android/issues/599

pcvengros commented 5 years ago

What cordova version?

I tried using your PR by doing cordova plugin add https://github.com/securCom/cordova-plugin-native-keyboard.git

And then running cordova platform add android@7.1.2

But I am still getting the following

Error during processing of action! Attempting to revert...
Failed to install 'cordova-plugin-native-keyboard': TypeError [ERR_INVALID_ARG_TYPE]: Uh oh!
The "path" argument must be of type string. Received type undefined
    at validateString (internal/validators.js:125:11)
    at Object.resolve (path.js:161:7)

It looks like it works if using cordova-android 7.1.4 but I have this problem in it that prevents me to update apache/cordova-android#599

dmastag commented 5 years ago

I am on the latest 8.1.2 Happy to say that my build is working as intended.

So android@7.1.2 not working with your pull request android@7.1.4 is working fine