search

EddyVerbruggen / cordova-plugin-safariviewcontroller

:tiger: :elephant: :crocodile: Forget InAppBrowser for iOS - this is way better for displaying read-only web content in your PhoneGap app
MIT License
282 stars 144 forks source link

Fix android build by migrating androidx modules #173

Closed ollwells closed 3 years ago

ollwells commented 3 years ago

I ran into issues attempting to use this plugin for a Ionic 5 capacitor project.

This seemed to be a common issue: https://github.com/EddyVerbruggen/cordova-plugin-safariviewcontroller/issues/155 https://github.com/EddyVerbruggen/cordova-plugin-safariviewcontroller/issues/157

I looked into it a bit more and saw android.support libraries are now replaced with androidx by default for Ionic.

So I changed the imports and found I was able to build and use the CustomTabs android implementation of this plugin. Here are the changes I made to get it to build and run.

This would appear to be a breaking change so I will leave with @EddyVerbruggen to decide on merging this change.

AresDev commented 3 years ago

@EddyVerbruggen could you please take a look? I'm facing this problem when installing fingerprint-aio plugin, I think it does something androidx related and there is a compatibility issue, and I need both plugins. Thanks!

dahLucky commented 3 years ago

I tested the pull request on Android 10 and can verify that it works as expected.

EddyVerbruggen commented 3 years ago

Thanks guys!

I'll do a major version bump, just to be on the safe side.