EddyVerbruggen / cordova-plugin-webviewcolor

MIT License
19 stars 11 forks source link

Not an issue but just a comment #1

Closed njtman closed 10 years ago

njtman commented 10 years ago

Hello, thanks for your great plugin. I just wanted to leave a comment here for you describing my fix.
I was essentially having the same problem as you were, and through googling I found this plugin, which is awesome.

I was having an issue where the select drop down translucent box was too dark. After looking at the source code for your plugin, it led me to find where Cordova is setting the black background color, which is making all the translucent UI elements look so dark.

On line 107 of MainViewController.m you see this line theWebView.backgroundColor = [UIColor blackColor];

Changing the color in this line to whiteColor fixes my problem. For my app I only have to change it once, so no plugin is needed (I don't need to dynamically change at run time).

It would be nice if you can document this alternate fix in your ReadMe file, so people don't unnecessarily download another plugin to do something so simple.

I realize people using PhoneGap build do not have access to modify these files, so you plugin is still very useful for some.

EddyVerbruggen commented 10 years ago

Hi! Thanks for the praise ;)

And thanks for pointing out it's mostly useful for PhoneGap Build users (and that's what is it is intended for indeed).

I engineered the plugin based on a locally build app of mine, for which I changed the exact same lines as you found did.. and then, after some complaints on a phonegap build user forum, I created this plugin for them.

I'm leaving this open as a reminder for a little update on the readme.

EddyVerbruggen commented 10 years ago

Updated the README, so closed, thanks!