search

EddyVerbruggen / nativescript-admob

NativeScript plugin to earn some precious :moneybag::moneybag: with ads by Google AdMob
MIT License
69 stars 26 forks source link

fix: works correctly with sdk version 17.0.0 #47

Closed Fatme closed 5 years ago

Fatme commented 5 years ago

Google AdMob publishers are required to specify a tag with key com.google.android.gms.ads.APPLICATION_ID in their AndroidManifest.xml as of Google Mobile Ads SDK version 17.0.0. Failure to add this tag results in a crash with the message: The Google Mobile Ads SDK was initialized incorrectly. More info can be found here: https://developers.google.com/admob/android/quick-start#update_your_androidmanifestxml

As a result from the above crash, {N} CLI is not able to start the application on device.

Refs to: https://github.com/NativeScript/nativescript-cli/issues/4029

EddyVerbruggen commented 5 years ago

Thanks! I'll update the readme to let the user know what to do (add the app id to app_resources) and bump the major version shortly.