search

EddyVerbruggen / nativescript-bluetooth-demo

30 stars 21 forks source link

Angular version #15

Open bapowell opened 7 years ago

bapowell commented 7 years ago

See the angular branch for a Nativescript-angular version of the demo.

EddyVerbruggen commented 7 years ago

Supercool! Can you point it at an angular branch? I mean, if I merge this now it will just overwrite master..

bapowell commented 7 years ago

My bad. I didn't mean to merge into your master branch. I meant for it to create a new angular branch in your repo, as it is in my forked repo. Let me see what I can do...

bapowell commented 7 years ago

Eddy, After some research it appears that GitHub doesn't support the automatic merging of a pull request to a new branch. I guess you'll have to do this manually:

Create/checkout the "angular" branch in your repo.

git checkout -b angular

Pull directly from my forked repo.

git pull https://github.com/bapowell/nativescript-bluetooth-demo.git angular

LucasBSC commented 5 years ago

This version still works fine?

rynop commented 5 years ago

@LucasBSC nope, but I just created an initial port of @bapowell 's work here: https://github.com/Akylas/nativescript-bluetooth/pull/9

I don't think @EddyVerbruggen actively maintains this plugin anymore, https://github.com/Akylas/nativescript-bluetooth is a fork of it that seems to be more active.

EddyVerbruggen commented 5 years ago

Ehm, I have not forgotten about this plugin.

rynop commented 5 years ago

Oh very sorry about that @EddyVerbruggen. I made the (incorrect) conclusion based on the age of https://github.com/EddyVerbruggen/nativescript-bluetooth-demo and https://github.com/EddyVerbruggen/nativescript-bluetooth file directory age:

image

I'll make a PR for Angular demo to your repo. Would you prefer it be a stand-alone repo like https://github.com/bapowell/nativescript-bluetooth-demo or a demo-ng like folder along side of demo? I'd prefer latter so things are more apt to keep updated, but am OK with either.

Wonder why Akylas fork hasn't made PRs back. It has been fairly active recently

EddyVerbruggen commented 5 years ago

@rynop No worries mate, I can understand it looks a bit stale but I have every intention to keep this plugin working and AFAIK it's still fully compatible with the latest NativeScript version.

I'd love to merge a demo-ng project in this plugin. That separate demo repo is a blast from the past where a certain cloud build environment wanted to be able to clone a standalone repo.

rynop commented 5 years ago

OK cool I'll send it soon. Have you ever reached out to maintainers of https://github.com/Akylas/nativescript-bluetooth? They have added a bunch of changes and it would be nice if all of us could put or collective effort into one codebase. For example, to PR to your codebase I'll have to update the startScanning() to not use the filters StartScanningOptions...

There is an issue I see from just a day ago asking them same question - I'll add a comment to it.

rynop commented 5 years ago

Sorry for all the updates. I'll give it a day or so to let Martin reply on urging him to PR back to https://github.com/EddyVerbruggen/nativescript-bluetooth

If he does, will kill 2 birds (I don't have to rework my code to fit your lib...)

drewcovi commented 5 years ago

@rynop is it required to build out a separate service as you did with /Bluetooth-ng/app/services/bluetooth.service.ts ?

I've been using 2.0.0 and successfully pulled it directly into my app.module.ts

However when I switched to Akylas fork, I ran into this issue on compile:

*** Terminating app due to uncaught exception 'NativeScript encountered a fatal error: Error: Can't resolve all parameters for Bluetooth: (?).
at
1   _reportError@file:///app/vendor.js:25162:27
2   _getDependenciesMetadata@file:///app/vendor.js:24974:34
3   _getTypeMetadata@file:///app/vendor.js:24867:50
4   getProviderMetadata@file:///app/vendor.js:25098:48
5   @file:///app/vendor.js:25036:68
6   forEach@[native code]
7   _getProvidersMetadata@file:///app/vendor.js:24996:26
8   getNgModuleMetadata@file:///app/vendor.js:24715:126
9   _loadModules@file:///app/vendor.js:31999:70
10  _compileModuleAndComponents@file:///app/vendor.js:31980:48
11  compileModuleAsync@file:///app/vendor.js:31940:64
12  bootstrapModule@file:///app/vendor.js:50098:38
13  _bootstrapper@file:///app/vendor.js:68230:50
14  @file:///app/vendor.js:68293:32
15  notify@file:///app/vendor.js:94749:31
16  @[native code]
17  notifyAppStarted@file:///app/vendor.js:91733:36
18  didFinishLaunchingWithOptions@file:///app/vendor.js:91725:3<\M-b\M^@\M-&>
rynop commented 5 years ago

@drewcovi AFAIK no. However that discussion is best suited for another thread.

rynop commented 5 years ago

@EddyVerbruggen can you take a look at https://github.com/Akylas/nativescript-bluetooth/issues/5#issuecomment-451515154 when you get a chance please? Can continue the "combine our efforts" discussion in that thread. Thanks