Testing environment for issue #5

EddyVerbruggen / nativescript-call

NativeScript plugin to interact with the native Call UI

Apache License 2.0

8 stars 4 forks source link

Testing environment for issue #5 #6

Closed brendtumi closed 5 years ago

brendtumi commented 5 years ago

PR Checklist

[x] The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.
[ ] There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
[x] All existing tests are passing
[ ] Tests for the changes are included

What is the current behavior?

Callkit windows is not op

What is the new behavior?

Create callkit screen on pushkit request while app is not running

Implements #5 .

EddyVerbruggen commented 5 years ago

Hi @brendtumi! I'm finally testing this PR. Sorry it took so long.

It looks like the delegate registers just fine, but I never get a token because pushRegistryDidUpdatePushCredentialsForType is not invoked. Do you have any suggestions perhaps?

brendtumi commented 5 years ago

You need an apple VOIP certificate for push token far as I know

EddyVerbruggen commented 5 years ago

Thanks @brendtumi, I tried that, but I was actually wondering which one of these you've used to test this:

The one at the top Apple Push Notification service SSL (Sandbox & Production), or at the bottom Apple Push Notification service SSL (Sandbox & Production) (I think I used the former, because it explicitly mentions it can be used for VoIP as well):

yerol commented 5 years ago

Voip Services Certificate is the right one