search

EddyVerbruggen / nativescript-directions

:point_up_2: :point_right: :point_down: :point_left: Open the Maps app to show directions to anywhere you like
MIT License
83 stars 21 forks source link

TS transpiling issue #4

Closed bradmartin closed 7 years ago

bradmartin commented 7 years ago

https://github.com/EddyVerbruggen/nativescript-directions/blob/master/directions.android.ts#L66

The current shipped .js has a bug, application_1 is not defined. I'll have a PR soon.

EddyVerbruggen commented 7 years ago

Oh really? Wow.. I think I have to monkeypatch other repo's as well then.

bradmartin commented 7 years ago

This could be something with tsconfig.json or the import itself. Not sure to be honest but the current source doesn't have the app module require statement so it always failed. Works great now though so might just want to check the output after transpiling to see what happens to application import.

On Thu, Nov 3, 2016, 2:38 AM Eddy Verbruggen notifications@github.com wrote:

Closed #4 https://github.com/EddyVerbruggen/nativescript-directions/issues/4.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/EddyVerbruggen/nativescript-directions/issues/4#event-846003156, or mute the thread https://github.com/notifications/unsubscribe-auth/AFulhNoptGAgCU9YJeNdEE5kEoaumKwbks5q6Y9xgaJpZM4Knx6W .