search

EddyVerbruggen / nativescript-gradient

:art: Easily add fancy (or subtle) gradient backgrounds to your views
MIT License
54 stars 6 forks source link

stop eddy - go drink a beer #1

Closed bradmartin closed 7 years ago

bradmartin commented 7 years ago

https://github.com/bradmartin/nativescript-gradient

EddyVerbruggen commented 7 years ago

W000000t!

I was actually drinking a beer :)

Thanks for the heads up, honestly didn't see it. I've already got iOS done though (Android at 75%) and it supports an arbitrary number of colors instead of 2. Also, I'm not going to require additional libraries for both platforms.

Ant preference on how to proceed?

bradmartin commented 7 years ago

I like your style 🍺 . Yea mine had 0 iOS support. The android side did use a native lib but not limited to colors - it just has a starting point/ending point (top left to bottom right and all variations of a square for a gradient). Ah you can take over the gradient if yours is gonna be x-plat and not add lib bloat 👍 . I've not transferred a package before on npm so need to figure that out but definitely can do.

bradmartin commented 7 years ago

Oh yea my old plugin is 2 colors - my bad. So yea yours is better - let's get yours to take over

EddyVerbruggen commented 7 years ago

Hey @bradmartin that would be very awesomely gentlemanlike of you! I've just finished the plugin and am now working on a little demo (with and without Angular).

According to the npm package ownership doc it's just a few commands to remove and add ownership. Why not leave yourself as owner and add me npm owner add eddyverbruggen nativescript-gradient, then I'll add you as a contributor to this GitHub repo as well.

I will then finish the plugin and bump it to 2.0.0 to not bite current users of the npm package.

EddyVerbruggen commented 7 years ago

The plugin is ready, pretty happy with the code & result ;)

bradmartin commented 7 years ago

I'll ping you shortly to discuss the transfer

On Wed, Jun 21, 2017, 7:45 AM Eddy Verbruggen notifications@github.com wrote:

The plugin is ready, pretty happy with the code & result ;)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/EddyVerbruggen/nativescript-gradient/issues/1#issuecomment-310067045, or mute the thread https://github.com/notifications/unsubscribe-auth/AFulhNLo5lNcpMZMOHyeH6TbSrR1fiuMks5sGRBUgaJpZM4OALgJ .

EddyVerbruggen commented 7 years ago

2.0.0 is now live on npm. Thanks Brad for the cooperation! 🤝