EddyVerbruggen / nativescript-localize

Internationalization plugin for NativeScript using native capabilities of each platform
MIT License
79 stars 31 forks source link

[tns-ios: 6.5.2] the fix for IOS 14 doesn't work properly #101

Closed kefahB closed 3 years ago

kefahB commented 3 years ago

Hi @NathanWalker and @EddyVerbruggen

I run my app on NS 6.5.2 and tns-ios: 6.5.2 I have updated nativescript-localize@4.2.2 the issue .ipa still there .. it seams that those lines cause the issue.

Keeping this like that work properly:

i18nEntries.forEach((value, key) => {
      if (key.startsWith("ios.info.plist.")) {
            infoPlistStrings.set(key.substr(15), value);
      }
});
EddyVerbruggen commented 3 years ago

Can you share your App_Resources/iOS/Info.plist?

kefahB commented 3 years ago

Here is :


<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
  <dict>
    <key>CFBundleDevelopmentRegion</key>
    <string>fr</string>
    <key>CFBundleDisplayName</key>
    <string>LightPAY</string>
    <key>CFBundleExecutable</key>
    <string>${EXECUTABLE_NAME}</string>
    <key>CFBundleInfoDictionaryVersion</key>
    <string>6.0</string>
    <key>CFBundleName</key>
    <string>${PRODUCT_NAME}</string>
    <key>CFBundlePackageType</key>
    <string>APPL</string>
    <key>CFBundleShortVersionString</key>
    <string>1.2.3</string>
    <key>CFBundleSignature</key>
    <string>????</string>
    <key>CFBundleVersion</key>
    <string>1.2.3</string>
    <key>LSRequiresIPhoneOS</key>
    <true/>
    <key>UILaunchStoryboardName</key>
    <string>LaunchScreen</string>
    <key>UIRequiresFullScreen</key>
    <true/>
    <key>UIRequiredDeviceCapabilities</key>
    <array>
      <string>armv7</string>
    </array>
    <key>UISupportedInterfaceOrientations</key>
    <array>
      <string>UIInterfaceOrientationPortrait</string>
    </array>
    <key>UISupportedInterfaceOrientations~ipad</key>
    <array>
      <string>UIInterfaceOrientationLandscapeLeft</string>
      <string>UIInterfaceOrientationLandscapeRight</string>
      <string>UIInterfaceOrientationPortrait</string>
      <string>UIInterfaceOrientationPortraitUpsideDown</string>
    </array>
    <key>NSAppTransportSecurity</key>
    <dict>
      <key>NSAllowsArbitraryLoads</key>
      <false/>
    </dict>
    <key>NSCameraUsageDescription</key>
    <string>We use the Camera for scan the Qr-code only.</string>
    <key>NSPhotoLibraryUsageDescription</key>
    <string>This app uses your photo library</string>
    <key>NSLocationWhenInUseUsageDescription</key>
    <string>${EXECUTABLE_NAME} need to use your current location ?</string>
    <key>NSLocationAlwaysUsageDescription</key>
    <string>${EXECUTABLE_NAME} need to use your current location for current use ?</string>
    <key>NSFaceIDUsageDescription</key>
    <string>For easy authentication with our app.</string>
    <key>UIBackgroundModes</key>
    <array>
      <string>fetch</string>
      <string>remote-notification</string>
    </array>
  </dict>
</plist>
EddyVerbruggen commented 3 years ago

LGTM. Not sure why you're having trouble..

You (not longer) have a CFBundleName key in App_resources/iOS/.lproj/InfoPlist.strings?

kefahB commented 3 years ago

App_resources/iOS/fr.lproj/InfoPlist.strings :


"CFBundleName" = "LightPAY";
"CFBundleDisplayName" = "LightPAY";

`
``
kefahB commented 3 years ago

I dont understand why also ! the conditions what I removed do no think special!

The issue run with tns build ios --bundle --release --for-device only but it work with tns run ios

EddyVerbruggen commented 3 years ago

That CFBundleName key should not be there according to the lines you linked to in your first comment. Maybe your environment needs some more aggressive cleaning?

kefahB commented 3 years ago

We maybe should wait until the others try to build theres app for appStore and see if the issue is from my environment :)