search

EddyVerbruggen / nativescript-localize

Internationalization plugin for NativeScript using native capabilities of each platform
MIT License
79 stars 31 forks source link

App name localization not working on iOS #12

Closed EddyVerbruggen closed 7 years ago

EddyVerbruggen commented 7 years ago

Hi,

Your library works great, except for one thing (that I've fixed with this PR): on iOS, the appname is always according to the default appname. Changing the language on the device doesn't have any effect.

The cause sees to be the encoding of the keys in InfoPlist.strings. The hook fi. changes CFBundleDisplayName to something like "_2ba372365d90c7cac414804b2aff4549d3e46ca8" which iOS can't relate back to theCFBundleDisplayName` key. At least not on my iOS 9 simulator.

Not encoding the keys in InfoPlist.strings fixes it.

Thanks, Eddy

EddyVerbruggen commented 7 years ago

Hi @lfabreges would you mind considering adding me as a collaborator on GitHub and granting me npm publish rights? I would really love continuing using your plugin without forking it, but I need this change published as on every npm i I need to manually patch node_modules.

lfabreges commented 7 years ago

Hi, thank you for your patience, just merged it, I'll push it to npm tonight.

EddyVerbruggen commented 7 years ago

Awesome, thanks so much!

lfabreges commented 7 years ago

@EddyVerbruggen, you're now a collaborator on this repository and npm, as I'm not very active right now on this plugin, that should be faster. Thanks.

EddyVerbruggen commented 7 years ago

That's great, thanks for trusting me with this 👍