search

EddyVerbruggen / nativescript-localize

Internationalization plugin for NativeScript using native capabilities of each platform
MIT License
79 stars 31 forks source link

update the README.md to include that app.name is mandatory #25

Closed jorotenev closed 6 years ago

jorotenev commented 6 years ago

Hi I got the same error as discussed here. At least for me, it wasn't clear enough that I'd need the app.name in the translation file/s. Given that I haven't changed my android manifest file, which references the @string/title_activity_kimera, I guess a few people might experience the same issue.

surdu commented 6 years ago

It should definitely be documented that app.name is a mandatory field.

As a funny side note: Having this problem now. Looking into issues: nothing. Looking into PRs: just one PR regarding some readme issue, clearly not what I'm struggling with ... ignoring. 😓

jorotenev commented 6 years ago

Good point. I edited the title.

surdu commented 6 years ago

Turns out it's mandatory for all translations when you build the app with tns build android --release, otherwise you'll get the following error:

Error: "_app_name_1k3Sbz" is n
ot translated in "es" (Spanish), "fr" (French) [MissingTranslation]
  <string name="_app_name_1k3Sbz">"AppName"</string>
          ~~~~~~~~~~~~~~~~~~~~~~~
lfabreges commented 6 years ago

Just published a new version that should resolve this issue