search

EddyVerbruggen / nativescript-plugin-firebase

:fire: NativeScript plugin for Firebase
https://firebase.google.com
MIT License
1.01k stars 441 forks source link

In App Messaging throws this error #1203

Closed tanekim88 closed 5 years ago

tanekim88 commented 5 years ago

When building with Firebase In App Messaging enabled, it throws this now. It was working before.

/Users/apple/Desktop/CSP/CAKE-Mobile/platforms/ios/Pods/FirebaseInAppMessagingDisplay/Firebase/InAppMessagingDisplay/ImageOnly/FIDImageOnlyViewController.m:154:29: error: property 'renderAsTestMessage' not found on object of type 'FIRInAppMessagingImageOnlyDisplay *' if (self.imageOnlyMessage.renderAsTestMessage)

aeliusdev commented 5 years ago

Same issue here

EddyVerbruggen commented 5 years ago

Hi, I don't see that specific issue, but indeed there seems to be some sort of build issue with InAppMessaging enabled.

Note that I don't officially support it yet (there's no mention in the docs yet), but this is obviously not what I intended either.

Which cocoapods version are you using? pod --version, and which NativeScript version? tns --version.

EddyVerbruggen commented 5 years ago

Btw, the implementation of InAppMessaging on iOS was blocked by issues with the appdelegate, but it looks like that can be fixed by implementing this: https://github.com/firebase/firebase-ios-sdk/pull/2354

Also, bumping the iOS Firebase SDK to the latest version seems to get rid of the build error I'm seeing, so this issue should be fixed soon.

tanekim88 commented 5 years ago

I remember updating pod and tns to the latest version last week, and it still didn't work.

HugoAntares commented 5 years ago

@EddyVerbruggen you closed this issue. But I still have the problem. Should I update something ?

EddyVerbruggen commented 5 years ago

I added the 8.2.0 milestone didn’t I? I’m on mobile so hard to check that quickly.

HugoAntares commented 5 years ago

@EddyVerbruggen indeed, the milestone 8.2.0 exists. Do you know when it'll be published ?

EddyVerbruggen commented 5 years ago

Working my ass of to get it out of the door. Hoping tomorrow.